[jbosstools-issues] [JBoss JIRA] (JBIDE-16393) Fix/recover for bad usage of submodules in VPE

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12938066#comment-12938066 ] 

Max Rydahl Andersen commented on JBIDE-16393:
---------------------------------------------

B - its referencing to a commit SHA to a repo with zero tags or branches. Sure we point to a sha1 but zero idea what changes since then are relevant for the branch we are pulling in from.
C /D - lets just wait do this before we are sure submodules are proper here
There is also F - with submodules you can't fork easily. Its just painful

I want to know where these git repos are forked from. Show original repos please.
If they are not forked from something that the commits can easily be merged back into or from then it is pointless to have them as submodules.

If they are clean repos that can be used to easily consume from and contribute to upstream then it makes sense - but then why are these not just done as proper maven projects we can depend on and integrate without using git submodules ?


                
> Fix/recover for bad usage of submodules in VPE
> ----------------------------------------------
>
>                 Key: JBIDE-16393
>                 URL: https://issues.jboss.org/browse/JBIDE-16393
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: browsersim, visual-page-editor-core
>    Affects Versions: 4.1.1.Final, 4.2.0.Alpha1
>            Reporter: Max Rydahl Andersen
>            Assignee: Ilya Buziuk
>            Priority: Critical
>             Fix For: 4.1.2.Final, 4.2.0.Alpha2
>
>
> both master and branch of vpe is using submodules
> https://github.com/jbosstools/jbosstools-vpe/blob/master/.gitmodules
> https://github.com/jbosstools/jbosstools-vpe/blob/jbosstools-4.1.x/.gitmodules
> Things wrong:
> A) These are pointing to personal repos
> B) No tags used
> C) readme.adoc not documenting it
> D) not announced anywhere
> E) git clone no longer sufficient
> We need to get this fixed/cleaned up in both branch and master.
>  *jbosstools-4.1.1.Final* - e498c091f79c140 ( JBIDE-15814 CordovaSim: Adding navigator.app.backHistory support )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira