[jbosstools-issues] [JBoss JIRA] (JBIDE-16393) Fix/recover for bad usage of submodules in VPE

[Ilya Buziuk (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16393?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12938158#comment-12938158 ] 

Ilya Buziuk commented on JBIDE-16393:
-------------------------------------

{quote}
     I want to know where these git repos are forked from. Show original repos please
{quote}
     ripple-temp is not actually forked. We have build https://github.com/apache/incubator-ripple and made a lot of changes for cordovasim. When I created a PR for ripple I did all changes          manually. In terms of  inspector-front-end. It's *front_end* folder from  https://chromium.googlesource.com/chromium/blink
{quote}
     C /D - lets just wait do this before we are sure submodules are proper here
{quote}
     Actually, we had original source, licence info in the about.html in the org.jboss.tools.vpe.cordovasim.ripple plugin (the submodule directory)
{quote}
      F - with submodules you can't fork easily.  Why are these not just done as proper maven projects we can depend on and integrate without using git submodules 
{quote}
      I didn't know about F. So, I guees maven projects is something that should be done for 4.2.0.Alpha2.  Probably for 4.1.2.Final we can make a hot fix - just remove ripple-temp submodule and push appropriate files directly from ripple-temp to  org.jboss.tools.vpe.cordovasim.ripple. If that sounds right I can make a PR
                
> Fix/recover for bad usage of submodules in VPE
> ----------------------------------------------
>
>                 Key: JBIDE-16393
>                 URL: https://issues.jboss.org/browse/JBIDE-16393
>             Project: Tools (JBoss Tools)
>          Issue Type: Task
>          Components: browsersim, visual-page-editor-core
>    Affects Versions: 4.1.1.Final, 4.2.0.Alpha1
>            Reporter: Max Rydahl Andersen
>            Assignee: Ilya Buziuk
>            Priority: Critical
>             Fix For: 4.1.2.Final, 4.2.0.Alpha2
>
>
> both master and branch of vpe is using submodules
> https://github.com/jbosstools/jbosstools-vpe/blob/master/.gitmodules
> https://github.com/jbosstools/jbosstools-vpe/blob/jbosstools-4.1.x/.gitmodules
> Things wrong:
> A) These are pointing to personal repos
> B) No tags used
> C) readme.adoc not documenting it
> D) not announced anywhere
> E) git clone no longer sufficient
> We need to get this fixed/cleaned up in both branch and master.
>  *jbosstools-4.1.1.Final* - e498c091f79c140 ( JBIDE-15814 CordovaSim: Adding navigator.app.backHistory support )

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira