[jbosstools-issues] [JBoss JIRA] (JBDS-2669) rename/refactor JBDS product .feature / plugin / .product to have less confusing names

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-2669?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12938589#comment-12938589 ] 

Max Rydahl Andersen commented on JBDS-2669:
-------------------------------------------

I'm trying to review this PR but it seems to not build. 

I think it is missing declaration of where to get it plugins from since i'm getting:

[INFO] Cannot complete the request.  Generating details.
[INFO] Cannot complete the request.  Generating details.
[INFO] {osgi.ws=cocoa, osgi.os=macosx, osgi.arch=x86, org.eclipse.update.install.features=true}
[ERROR] Cannot resolve project dependencies:
[ERROR]   Software being installed: com.jboss.devstudio.core.usage.branding 8.0.0.qualifier
[ERROR]   Missing requirement: com.jboss.devstudio.core.usage.branding 8.0.0.qualifier requires 'bundle org.jboss.tools.usage [1.0.0,2.0.0)' but it could not be found
[ERROR]
[ERROR] Internal error: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from com.jboss.devstudio.core.usage.branding 8.0.0.qualifier to bundle org.jboss.tools.usage [1.0.0,2.0.0).; No solution found because the problem is unsatisfiable.] -> [Help 1]
org.apache.maven.InternalErrorException: Internal error: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from com.jboss.devstudio.core.usage.branding 8.0.0.qualifier to bundle org.jboss.tools.usage [1.0.0,2.0.0).; No solution found because the problem is unsatisfiable.]
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:168)
	at org.apache.maven.cli.MavenCli.execute(MavenCli.java:537)
	at org.apache.maven.cli.MavenCli.doMain(MavenCli.java:196)
	at org.apache.maven.cli.MavenCli.main(MavenCli.java:141)
	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
	at java.lang.reflect.Method.invoke(Method.java:606)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launchEnhanced(Launcher.java:290)
	at org.codehaus.plexus.classworlds.launcher.Launcher.launch(Launcher.java:230)
	at org.codehaus.plexus.classworlds.launcher.Launcher.mainWithExitCode(Launcher.java:409)
	at org.codehaus.plexus.classworlds.launcher.Launcher.main(Launcher.java:352)
Caused by: java.lang.RuntimeException: No solution found because the problem is unsatisfiable.: [Unable to satisfy dependency from com.jboss.devstudio.core.usage.branding 8.0.0.qualifier to bundle org.jboss.tools.usage [1.0.0,2.0.0).; No solution found because the problem is unsatisfiable.]
	at org.eclipse.tycho.p2.resolver.AbstractResolutionStrategy.newResolutionException(AbstractResolutionStrategy.java:98)
	at org.eclipse.tycho.p2.resolver.ProjectorResolutionStrategy.resolve(ProjectorResolutionStrategy.java:88)
	at org.eclipse.tycho.p2.resolver.AbstractResolutionStrategy.resolve(AbstractResolutionStrategy.java:63)
	at org.eclipse.tycho.p2.impl.resolver.P2ResolverImpl.resolveDependencies(P2ResolverImpl.java:134)
	at org.eclipse.tycho.p2.impl.resolver.P2ResolverImpl.resolveDependencies(P2ResolverImpl.java:87)
	at org.eclipse.tycho.p2.resolver.P2TargetPlatformResolver.doResolvePlatform(P2TargetPlatformResolver.java:369)
	at org.eclipse.tycho.p2.resolver.P2TargetPlatformResolver.resolveDependencies(P2TargetPlatformResolver.java:345)
	at org.eclipse.tycho.core.resolver.DefaultTychoDependencyResolver.resolveProject(DefaultTychoDependencyResolver.java:109)
	at org.eclipse.tycho.core.maven.TychoMavenLifecycleParticipant.afterProjectsRead(TychoMavenLifecycleParticipant.java:75)
	at org.apache.maven.DefaultMaven.doExecute(DefaultMaven.java:274)
	at org.apache.maven.DefaultMaven.execute(DefaultMaven.java:156)
	... 11 more
                
> rename/refactor JBDS product .feature / plugin / .product to have less confusing names
> --------------------------------------------------------------------------------------
>
>                 Key: JBDS-2669
>                 URL: https://issues.jboss.org/browse/JBDS-2669
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: build, installer, updatesite
>    Affects Versions: 7.0.0.GA
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>            Priority: Critical
>             Fix For: 8.0.0.Alpha2
>
>         Attachments: update-product-manually-with-refactoring-full-featureset-review.png, update-product-manually-with-refactoring-full-featureset.png, update-product-manually-with-refactoring.png
>
>
> We should consider some better names for these artifacts so they collide less and are more obvious which is which.
> 1. https://github.com/jbdevstudio/jbdevstudio-product/blob/master/features/com.jboss.jbds.product.feature/feature.properties
> ** featureName=JBoss Developer Studio (Core Features) / BYOE category in update site
> 2. https://github.com/jbdevstudio/jbdevstudio-product/blob/master/plugins/com.jboss.jbds.product/plugin.properties and https://github.com/jbdevstudio/jbdevstudio-product/blob/master/plugins/com.jboss.jbds.product/META-INF/MANIFEST.MF
> ** Bundle-SymbolicName: com.jboss.jbds.product;singleton:=true
> 3. https://github.com/jbdevstudio/jbdevstudio-product/blob/master/site/com.jboss.jbds.product
> ** name="JBoss Developer Studio (Branded Product)" uid="com.jboss.jbds.all" id="com.jboss.jbds.product.product"

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira