[jbosstools-issues] [JBoss JIRA] (JBIDE-17838) Make discovery-site a Maven module

Nick Boldt (JIRA) issues at jboss.org
Wed Jul 9 10:27:25 EDT 2014


    [ https://issues.jboss.org/browse/JBIDE-17838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983544#comment-12983544 ] 

Nick Boldt commented on JBIDE-17838:
------------------------------------

{quote}it would probably be easier to maintain the discovery project{quote}

Please explain how moving this ant task into its own module makes it easier to maintain. I'm not adverse to the idea of simplifying maintenance, but this seems like arbitrary refactoring rather than a simplification.

Also, there are *TWO* discovery sites that can be generated for each jbosstools/ and jbdevstudio/ folder: one for Core and one for Early Access. Your PR moves only the Core one and forgets about the Early Access discovery sites:

https://github.com/jbosstools/jbosstools-discovery/blob/master/jbdevstudio/com.jboss.jbds.central.discovery.earlyaccess/pom.xml#L26-L58
https://github.com/jbosstools/jbosstools-discovery/blob/master/jbosstools/org.jboss.tools.central.discovery.earlyaccess/pom.xml#L26-L58

Also affected would be not just the publish.sh [0] script, but the promote.sh [1] script and we'd have to update all the doc [2]:

[0] https://github.com/jbosstools/jbosstools-build-ci/blob/master/publish/publish.sh
[1] https://github.com/jbosstools/jbosstools-build-ci/blob/master/publish/promote.sh
[2] https://github.com/jbosstools/jbosstools-discovery/blob/master/README.discovery.sites.adoc



> Make discovery-site a Maven module
> ----------------------------------
>
>                 Key: JBIDE-17838
>                 URL: https://issues.jboss.org/browse/JBIDE-17838
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build, discovery
>    Affects Versions: 4.2.0.Beta3
>            Reporter: Mickael Istria
>            Assignee: Nick Boldt
>            Priority: Minor
>             Fix For: 4.2.0.CR1
>
>
> Currently, the discovery-site is generated under on of the discovery plugin. Since it's a real artifact that we copy, deploy and that depends on several modules, it would probably be easier to maintain the discovery project if we create a dedicated module for the discovery site.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)


More information about the jbosstools-issues mailing list