[jbosstools-issues] [JBoss JIRA] (JBIDE-17838) Make discovery-site a Maven module

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17838?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983559#comment-12983559 ] 

Nick Boldt commented on JBIDE-17838:
------------------------------------

Agreed, nesting it under the discovery plugin is perhaps not straightforward, but ...

* what's the point of the site without the plugin?
* what's the point of the plugin, if it's not associated w/ a site?

You need both the plugin and the composite site, as well as the directory.xml file -- all three artifacts -- for a useful discovery site. Building them piecemeal is not a horrible idea, but since the plugin takes seconds to build, and the XML generation is quick too, there's not much savings from building the plugins separately from the site. And, too, if you start building the plugins separately, you would end up having to then rebuild the directory.xml (by hand) to pick up the new plugin's version.

So, since plugin.jar + directory.xml have to match version-wise, they ought to be built together.

And since the XML script that generates the directory.xml can also generate two tiny composite*.xml files at the same time, again, there's little point separating that into a new module so it can be built separately. If you did so, you'd have two calls to ant to produce XML files instead of 1.

Bottom line, you're making things more complex, not simpler.

---

As to the question of whether we need a discovery site for EA and for Central, given that we only use the generated one for EA (as it contains BOTH plugins and all the update sites)... today, we need both. 

Because Max is ADAMANT about the fact that EA != Central. So, to that end, I think it's important that we can independently build & test both the EA discovery site and the Central discovery site.

Ultimately, the Central discovery site may go away, but only if we get to a point where the EA one is empty. And, since JBT IS 4.2 / JBDS IS 8 will have to follow this same model, it's better if we have code that they can use to produce two different sites as well. 



> Make discovery-site a Maven module
> ----------------------------------
>
>                 Key: JBIDE-17838
>                 URL: https://issues.jboss.org/browse/JBIDE-17838
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build, discovery
>    Affects Versions: 4.2.0.Beta3
>            Reporter: Mickael Istria
>            Assignee: Nick Boldt
>            Priority: Minor
>             Fix For: 4.2.0.CR1
>
>
> Currently, the discovery-site is generated under on of the discovery plugin. Since it's a real artifact that we copy, deploy and that depends on several modules, it would probably be easier to maintain the discovery project if we create a dedicated module for the discovery site.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)