[jbosstools-issues] [JBoss JIRA] (JBIDE-17724) Changes cause full redeployment of exploded WAR

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17724?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12983672#comment-12983672 ] 

Rob Stryker commented on JBIDE-17724:
-------------------------------------

In general the patch looks good, but I won't approve it until tomorrow. I've tested it generally, but not in depth. 

What concerns me about this patch is the following usecase, though I'll need to test it more deeply to verify:

The zipped publisher will zip modules that must always be zipped. There's a list of them, but they consist of utility projects, application client projects, etc, things like this.   Now, it is still possible for one utility project (via module assembly) to reference or require another project be bundled inside it. Whether this is good practice or has any legitimate usecase is debatable. But the fact is using the module-assembly stuff, a utility project can include another module inside it. 

Let's assume we have the following projects:
1) Ear
2) Web
3) Utility project
4) Util2  (to be placed inside util.jar)


Assuming it is publishing exploded,  the ear will be published exploded first, then the war.  When it reaches the utility project, it will zip it (and all of its children modules, including Util2 in the above example) in the current codebase. 

If we can imagine an incremental publish, where project 3) (utility project) is unchanged, but project 4) IS changed, and 4) must be zipped INSIDE the zip for 3), we will have a problem. The provided patch will skip the publish for 3) since 3) has not changed,  and it will skip the publish for 4), assuming that 4) was already handled when 3) was handled. 

Again, this may be a niche case, but I'll need to investigate it more. 

> Changes cause full redeployment of exploded WAR
> -----------------------------------------------
>
>                 Key: JBIDE-17724
>                 URL: https://issues.jboss.org/browse/JBIDE-17724
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 4.2.0.Beta2
>         Environment: Windows 8.1 x64
> Java 7u51 x64
> Luna x64
>            Reporter: Cody Lerum
>            Assignee: Rob Stryker
>            Priority: Blocker
>              Labels: respin-a
>             Fix For: 4.2.0.Beta3, 4.2.0.CR1
>
>
> After moving to Luna from Kepler any changes to java or jsf resources are causing a full redeployment of the exploded war to JBoss 7.1.3.Final
> This prevents any updating of JSF resources or debugging java code.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)