[jbosstools-issues] [JBoss JIRA] (JBIDE-17910) Assign and List directive fixes and tests

Peter Palaga (JIRA) issues at jboss.org
Thu Jul 17 10:28:29 EDT 2014


Peter Palaga created JBIDE-17910:
------------------------------------

             Summary: Assign and List directive fixes and tests
                 Key: JBIDE-17910
                 URL: https://issues.jboss.org/browse/JBIDE-17910
             Project: Tools (JBoss Tools)
          Issue Type: Task
          Components: freemarker
            Reporter: Peter Palaga


(1) {{AssignmentDirective.isNestable()}} looks only if the directive ends with {{"/>}} which is simply wrong for {{assign}}, {{local}} and {{global}} directives. [{{assign}} documentation|http://freemarker.org/docs/ref_directive_assign.html] lists several possible variants of the directive. {{AssignmentDirective.isNestable()}} should cover them all and tests need to be added.

(2) It is clear from the usage of {{ItemSet.getFirstNestableItem(Stack<Item>)}} that it is supposed to return the last (as measured by time) item stored at the stack, not the first one. Therefore, {{getFirstNestableItem()}} needs to use a reverse order when iterating over the stack.

These two issues should fix the improper tree presented in outline (when rendered with {{OutlineContentProvider.fullAstShown}}.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)


More information about the jbosstools-issues mailing list