[jbosstools-issues] [JBoss JIRA] (JBIDE-17866) JSF/KB memory leak

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17866?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986446#comment-12986446 ] 

Viacheslav Kabanovich commented on JBIDE-17866:
-----------------------------------------------

Partial fix for 4.2.0 is suggested:
1. UniquePaths is cleaned.
2. KbProjectFactory.mockProjectStore is cleaned - that is enough to throw KbProject objects to the garbage collector.
3. Listeners added by XModel objects to resource model and Java model are removed.

At this time it is not easy to find all places that can hold XModel objects. The best way to approach the problem is to implement destroy() method that completely disassembles model structure and call it at project deletion. For sure, doing it now is unsafe because it will result in a lot of exceptions so that I suggest implementing it in the next version.
XModelMetaDataImpl object should not be released - it contains metadata which is used not only for projects but also for wizards and preferences. There is no way to separate safely part of metadata that can be released.

> JSF/KB memory leak
> ------------------
>
>                 Key: JBIDE-17866
>                 URL: https://issues.jboss.org/browse/JBIDE-17866
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsf
>    Affects Versions: 4.2.0.Beta3
>            Reporter: Fred Bricon
>            Assignee: Viacheslav Kabanovich
>             Fix For: 4.2.0.CR1
>
>
> Playing with m2e 1.6 on my new MBP, I imported the [wildfly|https://github.com/wildfly/wildfly] [projects|https://github.com/wildfly/wildfly-core] in my workspace, then deleted everything.
> Before import heap was at ~80MB, after th 135 projects and forcing GC, it doesn't go down 280MB. I then took a heap dump (https://www.dropbox.com/s/gmxy6ofdwrtb8g2/java_pid14384.0002.hprof.zip), loaded it into Eclipse Memory Analyzer and looked for org.jboss.* components.
> It seems we retain many XModelMetadataIpl, JSF2Project, KbProject instances and a bunch of other JBT classes, that should be cleaned up when projects are deleted from workspace
> !http://content.screencast.com/users/fbricon/folders/Jing/media/218ef77b-df6a-44f8-864d-f6d6fb8999e7/00000001.png!



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)