[jbosstools-issues] [JBoss JIRA] (JBIDE-17676) Angular Code Assist doesn't work for angular phonecat app

[Victor Rubezhny (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17676?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12986956#comment-12986956 ] 

Victor Rubezhny edited comment on JBIDE-17676 at 7/22/14 6:42 AM:
------------------------------------------------------------------

bq. Regarding to this issue should I change it to Feature request\?

IMHO, the answer is NO. We are not able to provide some feature for absolutely all kinds of projects. We have to restrict our features to work on some specified kind of nature and JavaScript nature is good candidate to be the one for using Tern.java/Angular.js. 

There are three kind of Angular related editing facilities:

* JBoss Tools - Content Assist and Palette for Angular.JS in HTML files
* Tern.java - Content Assist in JavaScript files
* AngularJS-eclipse - Content Assist in HTML files

Tern.java/AngularJS-eclipse are set up (by us) to work on any project that has JavaScript nature. But, as your example with phone-info.html demonstrates, AngularJS-eclipse cannot provide it's Content Assist facilities for any HTML file. The same situation is for the JBoss Tools one.

Particularly for Angular, we cannot provide Content Assist for any HTML file. AFAIK, we're detecting the referencing to angular.js script and usage of ng-* tag attributes, and provide Angular Content Assist and Palette for such files But often HTML files are used as templates, or are built using templates and might not contain any references to angular/don't use ng-* attributes, so we can't to be sure that we have to provide Angular Content Assist for such HTML pages.

We've planned some work due to make it possible to detect if Angular is used in a whole project, so, this may help with Content Assist for such HTML Files (where per-file Angular detection doesn't work), but this will not guarantee, that such project-wise detection will work smoothly right from the time of creating/importing test project.

bq. According to this http://tools.jboss.org/documentation/whatsnew/jbosstools/4.2.0.Beta2.html#jst AngularJS code completion should be available in JBoss Tools HTML editor. 

The requirement to have at least JavaScript nature should be documented.

bq. Could you give me a project where I can test it please?

[~akazakov] Do you have a suitable test project for Vlado in order to test Angular-related text editing features?


was (Author: vrubezhny):
bq. Regarding to this issue should I change it to Feature request\?

IMHO, the answer is NO. We are not able to provide some feature for absolutely all kinds of projects. We have to restrict our features to work on some specified kind of nature and JavaScript nature is good candidate to be the one for using Tern.java/Angular.js. 

There are three kind of Angular related editing facilities:

* JBoss Tools - Content Assist and Palette for Angular.JS in HTML files
* Tern.java - Content Assist in JavaScript files
* AngularJS-eclipse - Content Assist in HTML files

Tern.java/AngularJS-eclipse are set up (by us) to work on any project that has JavaScript nature. But, as your example with phone-info.html demonstrates, AngularJS-eclipse cannot provide it's Content Assist facilities for any HTML file. The same situation is for the JBoss Tools one.

Particularly for Angular, we cannot provide Content Assist for any HTML file. AFAIK, we're detecting the referencing to angular.js script and usage of ng-* tag attributes, and provide Angular Content Assist and Palette for such files But often HTML files are used as templates, or are built using templates and might not contain any references to angular/don't use ng-* attributes, so we can't to be sure that we have to provide Angular Content Assist for such HTML pages.

We've planned some work due to make it possible to detect if Angular is used in a whole project, so, this may help with Content Assist for such HTML Files (where per-file Angular detection doesn't work), but this will not guarantee, that such project-wise detection will work smoothly right from the time of creating/importing test project.

bq. According to this http://tools.jboss.org/documentation/whatsnew/jbosstools/4.2.0.Beta2.html#jst AngularJS code completion should be available in JBoss Tools HTML editor. 

The requirement to have at least JavaScript nature should be documented.

bq. Could you give me a project where I can test it please?

[~akazakov] Do you have a suitable test project for Vlado in order to test Angular-related text editing features01?

> Angular Code Assist doesn't work for angular phonecat app
> ---------------------------------------------------------
>
>                 Key: JBIDE-17676
>                 URL: https://issues.jboss.org/browse/JBIDE-17676
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml/html source editing
>    Affects Versions: 4.2.0.Beta2
>         Environment: JBT 4.2.0.Beta2, Linux, AngulaJS for Eclipse installed from JBoss Central Early access
>            Reporter: Vlado Pakan
>            Assignee: Victor Rubezhny
>             Fix For: 4.2.0.CR1
>
>         Attachments: angular.png, phonecatControllers.png
>
>
> 1. Follow steps from JBIDE-16544 to import angular phonecat project
> 2. Open controllers.js in Java Script editor
> ERROR: There is no code assist for angular.| or phonecatControllers.|
> 3. Open phone-detail.html
> ERROR: There is no code assist for {{|}} or {{phone.|}}
> Is it not supported scenario?



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)