[jbosstools-issues] [JBoss JIRA] (JBIDE-17904) Make .gitignore addition smarter and add comments to ignored files

[Marián Labuda (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-17904?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Marián Labuda updated JBIDE-17904:
----------------------------------

    Description: 
currently *Any* openshift app creation/import we add the following blindly:
{code}
target
.settings/*
!.settings/.jsdtscope
.classpath
{code}

These does not make much sense for most apps besides java.

Can't we be a bit more intelligent about it ? 
i.e. if the project is not a maven project, don't add 'target'
if project is not a java project do not add .classpath

And then I suggest adding comments to the .gitignore to make it clear what they do:
{code}
# if you want *all* eclipse settings to be shared comment this out, otherwise leave in.
.settings/*
# keep .jsdtscope to share javascript validations exclusions to avoid too many false positive warnings
!.settings/.jsdtscope
{code}

  was:
currently *Any* openshift app creation/import we add the following blindly:

target
.settings/*
!.settings/.jsdtscope
.classpath

These does not make much sense for most apps besides java.

Can't we be a bit more intelligent about it ? 
i.e. if the project is not a maven project, don't add 'target'
if project is not a java project do not add .classpath

..and then I suggest adding comments to the .gitignore to make it clear what they do:

# if you want *all* eclipse settings to be shared comment this out, otherwise leave in.
.settings/*
# keep .jsdtscope to share javascript validations exclusions to avoid too many false positive warnings
!.settings/.jsdtscope



> Make .gitignore addition smarter and add comments to ignored files
> ------------------------------------------------------------------
>
>                 Key: JBIDE-17904
>                 URL: https://issues.jboss.org/browse/JBIDE-17904
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.2.0.Beta3
>            Reporter: Max Rydahl Andersen
>             Fix For: 4.3.x
>
>
> currently *Any* openshift app creation/import we add the following blindly:
> {code}
> target
> .settings/*
> !.settings/.jsdtscope
> .classpath
> {code}
> These does not make much sense for most apps besides java.
> Can't we be a bit more intelligent about it ? 
> i.e. if the project is not a maven project, don't add 'target'
> if project is not a java project do not add .classpath
> And then I suggest adding comments to the .gitignore to make it clear what they do:
> {code}
> # if you want *all* eclipse settings to be shared comment this out, otherwise leave in.
> .settings/*
> # keep .jsdtscope to share javascript validations exclusions to avoid too many false positive warnings
> !.settings/.jsdtscope
> {code}



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)