[jbosstools-issues] [JBoss JIRA] (JBIDE-17905) Server Adapter: cannot publish commits (only) when there are local changes (can only commit and push)

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17905?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12988234#comment-12988234 ] 

Andre Dietisheim edited comment on JBIDE-17905 at 7/28/14 9:18 AM:
-------------------------------------------------------------------

In JBIDE-17190 we started presenting the commit dialog in the initial import and stopped doing an automatic commit. The new dialog allowed people to inspect the changes that the import did and to choose to commit/not commit them before possibly pushing changes back to OpenShift.
In the UX review it turned out that the commit dialog was unexpected to the newbie user, he did not understand why he would have to commit changes upon import.
In a discussion with [~maxandersen] we now decided to not commit the changes upon import (we'll make them more clever though: JBIDE-17904). This implies that we wont push local changes back to OpenShift automatically (as we we started doing it with JBIDE-13075). I've filed this additional change to JBIDE-17984 


was (Author: adietish):
In JBIDE-17190 we started presenting the commit dialog in the initial import and stopped doing an automatic commit. The new dialog allowed people to inspect the changes that the import did and to choose to commit/not commit them before possibly pushing changes back to OpenShift.
In the UX review it turned out that the commit dialog was unexpected to the newbie user, he did not understand why he would have to commit changes upon import.
In a discussion with [~maxandersen] we now decided to not commit the changes upon import (we'll make them more clever though: JBIDE-17904). This implies that we wont push local changes back to OpenShift automatically (as we we started doing it with JBIDE-13075) 

> Server Adapter: cannot publish commits (only) when there are local changes (can only commit and push)
> -----------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-17905
>                 URL: https://issues.jboss.org/browse/JBIDE-17905
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Assignee: Andre Dietisheim
>            Priority: Critical
>              Labels: server_adapter
>             Fix For: 4.2.0.CR1
>
>
> # EXEC: Add file test.txt
> # EXEC: Commit test.txt
> # EXEC: Add file temporary.txt
> # EXEC: go to openshift server and publish
> # ASSERT: commit dialog shows up 
> # ASSERT:  I can push the new commits without having to do something about temporary.txt
> this worked in past, now the new commit dialog prevents me from doing this.
> I can use egit push to workaround this but that kinda defeats the purpose of making the server interaction simple via just the "Publish" command.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)