[jbosstools-issues] [JBoss JIRA] (JBIDE-18008) Nested jars prevent SonarQube/FindBugs from running

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989436#comment-12989436 ] 

Rob Stryker commented on JBIDE-18008:
-------------------------------------

Archives tools will, via UI, allow a user to customize how a set of projects can be built, zipped, etc.  This configuration is stored in a .packages file, which is an xml file of our own custom structure. 

Users at one time requested the ability to run this .packages file from ant, without having to pull in huge portions of eclipse onto the ant classpath. This required careful separation of the code so that the contents of archivescore.jar would require only very very few eclipse jars on its classpath, while the remainder of the code lived in archivescore-eclipse.jar. 

The code in archivescore.jar (currently) needs to be accessible via an ant script. This means it must be a jar that lives inside an exploded plugin.  Users would make an ant script, add archivescore.jar and a handful of eclipse jars to the classpath, set some properties, and be able to build a .packages file into its output archive.   The ant task itself lives in archivescore.jar

> Nested jars prevent SonarQube/FindBugs from running
> ---------------------------------------------------
>
>                 Key: JBIDE-18008
>                 URL: https://issues.jboss.org/browse/JBIDE-18008
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: archives
>            Reporter: Mickael Istria
>             Fix For: 4.2.0.CR1
>
>
> Bundle org.jboss.ide.eclipse.archives.core makes SonarQube analysis fail because it's classes get included in some nested jar (and get to different location that target/classes).
> Cf https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Sonar/job/jbosstools-server.sonar_master/4/console
> {code}
> [ERROR] Failed to execute goal org.codehaus.mojo:sonar-maven-plugin:2.4:sonar (default-cli) on project server.all: Can not execute SonarQube analysis: Can not execute Findbugs: Findbugs needs sources to be compiled. Please build project before executing sonar and check the location of compiled classes. -> [Help 1]
> {code}
> This is an exploded bundles with nested jars, we should investigate whether it's possible to turn it into a more standard jar, which would still be usable in its Ant version. Cf ./archives/tests/org.jboss.ide.eclipse.archives.test/inputs/projects/SimpleAntTest
> Also, the jvmmonitor bundles use nested jars. We should avoid that too.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)