[jbosstools-issues] [JBoss JIRA] (JBIDE-18008) Nested jars prevent SonarQube/FindBugs from running

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18008?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12989522#comment-12989522 ] 

Rob Stryker commented on JBIDE-18008:
-------------------------------------

1) create java project, add some folders and files and junk
2) Show view -> project archives
3) select project, right-click, new archive
4) fill in all required info
5) do optional additional stuff, like add folders inside your archive, or nested archives, or filesets
6) .packages file exists

I would honestly suggest NOT changing the packaging here. Seriously.  If I can get rid of, or deprecate, the external ant usecase, I can turn this into a standard plugin which would automatically simplify the plugin structure.  I feel you're just duplicating effort. 

> Nested jars prevent SonarQube/FindBugs from running
> ---------------------------------------------------
>
>                 Key: JBIDE-18008
>                 URL: https://issues.jboss.org/browse/JBIDE-18008
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: archives
>            Reporter: Mickael Istria
>            Assignee: Mickael Istria
>             Fix For: 4.2.0.CR1
>
>
> Bundle org.jboss.ide.eclipse.archives.core makes SonarQube analysis fail because it's classes get included in some nested jar (and get to different location that target/classes).
> Cf https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Sonar/job/jbosstools-server.sonar_master/4/console
> {code}
> [ERROR] Failed to execute goal org.codehaus.mojo:sonar-maven-plugin:2.4:sonar (default-cli) on project server.all: Can not execute SonarQube analysis: Can not execute Findbugs: Findbugs needs sources to be compiled. Please build project before executing sonar and check the location of compiled classes. -> [Help 1]
> {code}
> This is an exploded bundles with nested jars, we should investigate whether it's possible to turn it into a more standard jar, which would still be usable in its Ant version. Cf ./archives/tests/org.jboss.ide.eclipse.archives.test/inputs/projects/SimpleAntTest
> Also, the jvmmonitor bundles use nested jars. We should avoid that too.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)