[jbosstools-issues] [JBoss JIRA] (JBIDE-17509) NPE in ModuleSlotManifestUtil

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-17509?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-17509.
---------------------------------

      Assignee: Rob Stryker
    Resolution: Done


Committed what I think is a fix. It's not obvious how this null is getting there, though. There's only 2 entry points for these methods and I don't see any obvious code that can set a null.   It checks if the key is in the map, and if it's not, it generates a clean array as the value. 

The only way this NPE can be hit is if someone previously did a set(project, null), or something like that. 

Anyway, added null protection as best as I could, but still... confusing.

Denis: any steps to replicate? Help QE out a bit here. 

> NPE in ModuleSlotManifestUtil
> -----------------------------
>
>                 Key: JBIDE-17509
>                 URL: https://issues.jboss.org/browse/JBIDE-17509
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: server
>    Affects Versions: 4.2.0.Beta2
>            Reporter: Denis Golovin
>            Assignee: Rob Stryker
>             Fix For: 4.2.0.Beta3
>
>
> {code}java.lang.NullPointerException
> 	at java.util.Arrays$ArrayList.<init>(Arrays.java:2842)
> 	at java.util.Arrays.asList(Arrays.java:2828)
> 	at org.jboss.ide.eclipse.as.classpath.core.runtime.modules.manifest.ModuleSlotManifestUtil.esureInCache(ModuleSlotManifestUtil.java:58)
> 	at org.jboss.ide.eclipse.as.classpath.core.runtime.internal.ManifestChangeListener.resourceChanged(ManifestChangeListener.java:69)
> 	at org.eclipse.core.internal.events.NotificationManager$1.run(NotificationManager.java:291)
> 	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> 	at org.eclipse.core.internal.events.NotificationManager.notify(NotificationManager.java:285)
> 	at org.eclipse.core.internal.events.NotificationManager.broadcastChanges(NotificationManager.java:149)
> 	at org.eclipse.core.internal.resources.Workspace.broadcastBuildEvent(Workspace.java:384)
> 	at org.eclipse.core.internal.events.AutoBuildJob.doBuild(AutoBuildJob.java:139)
> 	at org.eclipse.core.internal.events.AutoBuildJob.run(AutoBuildJob.java:241)
> 	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54){code}



--
This message was sent by Atlassian JIRA
(v6.2.3#6260)