[jbosstools-issues] [JBoss JIRA] (JBIDE-17579) Incorrect code formating when dropping from Palette inside a comment node

Tue Jun 10 14:25:15 EDT 2014

     [ https://issues.jboss.org/browse/JBIDE-17579?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Alexey Kazakov updated JBIDE-17579:
-----------------------------------

    Description: 
1. Create the following HTML5 file:
{code}
<!DOCTYPE html> 
<html> 
 <head> 
        <title>My Page</title> 
        <meta name="viewport" content="width=device-width, initial-scale=1"> 
        <link rel="stylesheet" href="http://code.jquery.com/mobile/1.4.0-rc.1/jquery.mobile-1.4.0-rc.1.min.css" />
        <script src="http://code.jquery.com/jquery-1.10.2.min.js"></script>
        <script src="http://code.jquery.com/mobile/1.4.0-rc.1/jquery.mobile-1.4.0-rc.1.min.js"></script>
 </head> 
 <body>

	<div data-role="page" id="page-1">
		<div data-role="header">
			<h1>Page Title</h1>
		</div>
		<div data-role="content">
			<p>Page content goes here.</p>
			<!--comment-->
			<a href="" id="button-1" class="ui-btn ui-icon-bars ui-btn-icon-left ui-corner-all">Link button</a>
		</div>
	</div>

 </body>
</html>
{code}
2. Drop a "Button" item from JQM Palette right after the <!--comment--> node (in the end of that line)
*Assert:*
{code}
...
		<div data-role="content">
			<p>Page content goes here.</p>
			<!--comment-->
			<a href="" id="button-2" class="ui-btn ui-corner-all">Link button</a>
			<a href="" id="button-1" class="ui-btn ui-icon-bars ui-btn-icon-left ui-corner-all">Link button</a>
		</div>
...
{code}
*Failure:* (see an extra tab symbol before <a>)
{code}
...
		<div data-role="content">
			<p>Page content goes here.</p>
			<!--comment-->
				<a href="" id="button-2" class="ui-btn ui-corner-all">Link button</a>
			<a href="" id="button-1" class="ui-btn ui-icon-bars ui-btn-icon-left ui-corner-all">Link button</a>
		</div>
...
{code}

  was:
Position of insert shouldbe moved outside of comment nodes in the same way as it works for opening/closing tags of elements.

1. Open an html 5 file
{code}
<!DOCTYPE html> 
<html> 
 <head> 
        <title>My Page</title> 
        <meta name="viewport" content="width=device-width, initial-scale=1"> 
        <link rel="stylesheet" href="http://code.jquery.com/mobile/1.4.0-rc.1/jquery.mobile-1.4.0-rc.1.min.css" />
        <script src="http://code.jquery.com/jquery-1.10.2.min.js"></script>
        <script src="http://code.jquery.com/mobile/1.4.0-rc.1/jquery.mobile-1.4.0-rc.1.min.js"></script>
 </head> 
 <body>

	<div data-role="page" id="page-1">
		<div data-role="header">
			<h1>Page Title</h1>
		</div>
		<div data-role="content">
			<p>Page content goes here.</p>
			<!--comment-->
			<a href="" id="button-1" class="ui-btn ui-icon-bars ui-btn-icon-left ui-corner-all">Link button</a>
		</div>
	</div>

</body>
</html>
{code}
2. Drop "Text Input" item from Mobile Palette into  node.

Assert: Template is inserted before or after the comment node, what is the nearest.
Failure: Template is inserted inside the comment node.

> Incorrect code formating when dropping from Palette inside a comment node
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-17579
>                 URL: https://issues.jboss.org/browse/JBIDE-17579
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml/html source editing
>            Reporter: Alexey Kazakov
>            Assignee: Viacheslav Kabanovich
>             Fix For: 4.2.0.Beta3
>
>
> 1. Create the following HTML5 file:
> {code}
> <!DOCTYPE html> 
> <html> 
>  <head> 
>         <title>My Page</title> 
>         <meta name="viewport" content="width=device-width, initial-scale=1"> 
>         <link rel="stylesheet" href="http://code.jquery.com/mobile/1.4.0-rc.1/jquery.mobile-1.4.0-rc.1.min.css" />
>         <script src="http://code.jquery.com/jquery-1.10.2.min.js"></script>
>         <script src="http://code.jquery.com/mobile/1.4.0-rc.1/jquery.mobile-1.4.0-rc.1.min.js"></script>
>  </head> 
>  <body>
> 	<div data-role="page" id="page-1">
> 		<div data-role="header">
> 			<h1>Page Title</h1>
> 		</div>
> 		<div data-role="content">
> 			<p>Page content goes here.</p>
> 			<!--comment-->
> 			<a href="" id="button-1" class="ui-btn ui-icon-bars ui-btn-icon-left ui-corner-all">Link button</a>
> 		</div>
> 	</div>
>  </body>
> </html>
> {code}
> 2. Drop a "Button" item from JQM Palette right after the <!--comment--> node (in the end of that line)
> *Assert:*
> {code}
> ...
> 		<div data-role="content">
> 			<p>Page content goes here.</p>
> 			<!--comment-->
> 			<a href="" id="button-2" class="ui-btn ui-corner-all">Link button</a>
> 			<a href="" id="button-1" class="ui-btn ui-icon-bars ui-btn-icon-left ui-corner-all">Link button</a>
> 		</div>
> ...
> {code}
> *Failure:* (see an extra tab symbol before <a>)
> {code}
> ...
> 		<div data-role="content">
> 			<p>Page content goes here.</p>
> 			<!--comment-->
> 				<a href="" id="button-2" class="ui-btn ui-corner-all">Link button</a>
> 			<a href="" id="button-1" class="ui-btn ui-icon-bars ui-btn-icon-left ui-corner-all">Link button</a>
> 		</div>
> ...
> {code}

--
This message was sent by Atlassian JIRA
(v6.2.3#6260)