[jbosstools-issues] [JBoss JIRA] (JBIDE-17616) bring back externally managed to server and new wizard UI

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17616?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12976400#comment-12976400 ] 

Rob Stryker commented on JBIDE-17616:
-------------------------------------

There is no reasonable way to have this in both places.  If we're storing this in two different places (server and launch-config), there's no easy way to get the actual value. Here are the complications.

Let's follow this workflow. Assume the value in both server and launchconfig is either 'false' or null. 

1) User opens server editor
2) Server editor has to check launch config for its value
3) Server editor checks server value,  then or's together with 2)
4) Value false || false, so the box is left unchecked. 
5) User changes it to true (checks the box) in server editor
6) User clicks on 'launch config'
7) User is prompted to save server editor. The user may or may not save the editor ***
8) Launch config opens, sees server has value true, launch has value false, marks box as checked. 
9) The user decides to uncheck this value in the launch config. 
10) When the user persists the launch config, the launch config *cannot* make changes to the server. It does have a reference to it, but, the server may already have a working copy in the editor if the user did not save it. The launch config only has a reference to teh IServer, not the existing working copy.  The launch config cannot simply change the value here and save it without invalidating the editor. If the user made multiple other changes, this would overwrite all their changes. 
11) The user persists his uncheck, but the server itself still has a value of true. This means the server editor will still see this as 'checked'
12) The user re-opens the launch config.  Since the server still has a value of 'true', the checkbox will still be checked. 

In short, the launch config editor cannot make changes to the server editor or the server working copy.  It then becomes impossible to keep both values in sync with each other. 

> bring back externally managed to server and new wizard UI
> ---------------------------------------------------------
>
>                 Key: JBIDE-17616
>                 URL: https://issues.jboss.org/browse/JBIDE-17616
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: server
>            Reporter: Max Rydahl Andersen
>            Priority: Critical
>
> in JBIDE-17076 externally managed was *moved* into launch UI even though that externally managed defaults to false and when users enable it launch configurations becomes irrelevant.
> Why can't we have it both so we do not have to get users to work with launch configuraiton UI for the simple case of not wanting to start a server but just connect to what is there ?



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)