[jbosstools-issues] [JBoss JIRA] (JBDS-3071) JBDS Installer shouldn't contain source features/plugins

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12977447#comment-12977447 ] 

Nick Boldt commented on JBDS-3071:
----------------------------------

[~dgolovin] as far as I can see the installer build process simply unpacks the previously-built JBDS update site zip:

{code:title=https://github.com/jbdevstudio/jbdevstudio-product/blob/master/installer/pom.xml#L117-L135}
          <execution>
            <id>unpack</id>
            <phase>prepare-package</phase>
            <goals>
              <goal>unpack</goal>
            </goals>
            <configuration>
              <artifactItems>
                <artifactItem>
                  <groupId>com.jboss.devstudio.core</groupId>
                  <artifactId>com.jboss.devstudio.core.site</artifactId>
                  <version>${project.version}</version>
                  <type>zip</type>
                </artifactItem>
              </artifactItems>
              <outputDirectory>${project.build.directory}/update/jbds</outputDirectory>
              <excludes>**/*.pack.gz</excludes>
            </configuration>
          </execution>
{code}

Then that folder is composited directly using https://github.com/jbdevstudio/jbdevstudio-product/blob/master/installer/src/main/resources/compositeArtifacts.xml and https://github.com/jbdevstudio/jbdevstudio-product/blob/master/installer/src/main/resources/compositeContent.xml within the root of the installer jar.

So... we would need to perform a p2 installation instead of a simple unpack, or else an unpack followed by a metadata regeneration so the site wouldn't contain source plugins/features.

> JBDS Installer shouldn't contain source features/plugins
> --------------------------------------------------------
>
>                 Key: JBDS-3071
>                 URL: https://issues.jboss.org/browse/JBDS-3071
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: installer
>    Affects Versions: 8.0.0.Beta2
>            Reporter: Fred Bricon
>            Assignee: Nick Boldt
>             Fix For: 8.0.0.Beta3
>
>
> {quote}
> So the basic JBDS installer is 70MB fatter. From my understanding it's because we now ship a *huge* forge2 runtime (50MB), Tern, the JVM Monitor and probably some other minor stuff.
> Fair enough. But do we *really* need to add all the source features/plugins to the installer? *If* we're legally bound to provide sources for JBoss plugins, couldn't we provide them via an other way? (p2 only).
> I reckon we could save ~37 MB by not shipping sources in the installer. I know storage is cheap and d/l speeds are faster but that's not an excuse.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)