[jbosstools-issues] [JBoss JIRA] (JBIDE-17468) Assign proper VM to tomcat runtimes

[Fred Bricon (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-17468?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Fred Bricon resolved JBIDE-17468.
---------------------------------

      Assignee: Rob Stryker  (was: Fred Bricon)
    Resolution: Done


One more commit to make the tests more IDE friendly : https://github.com/jbosstools/jbosstools-server/commit/fef709fd0b2c7d3ecee35457d5d099536d4461f8

> Assign proper VM to tomcat runtimes
> -----------------------------------
>
>                 Key: JBIDE-17468
>                 URL: https://issues.jboss.org/browse/JBIDE-17468
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: runtime-detection, server
>    Affects Versions: 4.2.0.Beta2
>            Reporter: Nick Boldt
>            Assignee: Rob Stryker
>             Fix For: 4.2.0.Beta3
>
>
> It appears the tomcat runtime detector fails to properly detect tomcat 8 instances when run with JDK 6, which caused the test failures in JBIDE-17288 :
> {code:title=https://jenkins.mw.lab.eng.bos.redhat.com/hudson/view/DevStudio/view/DevStudio_Master/job/jbosstools-server_master/493/testReport/org.jboss.tools.wtp.runtimes.tomcat.tests/TomcatDetectionTest/testTomcatDetection/}
> Error Message
> expected:<3> but was:<2>
> Stacktrace
> java.lang.AssertionError: expected:<3> but was:<2>
> 	at org.junit.Assert.fail(Assert.java:88)
> 	at org.junit.Assert.failNotEquals(Assert.java:743)
> 	at org.junit.Assert.assertEquals(Assert.java:118)
> 	at org.junit.Assert.assertEquals(Assert.java:555)
> 	at org.junit.Assert.assertEquals(Assert.java:542)
> 	at org.jboss.tools.wtp.runtimes.tomcat.tests.TomcatDetectionTest.testTomcatDetection(TomcatDetectionTest.java:64)
> {code}
> Tomcat 8 needs a JDK 7 to be properly set. [~nickboldt]'s PR, while strenghtening the tests, is not enough to address the issue/ So instead of using the default VM, we should assign the most appropriate one in the detector.



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)