[jbosstools-issues] [JBoss JIRA] (JBIDE-17672) Contribute changes to EGit commit/push operation to allow our custom server adapter publishing

Andre Dietisheim (JIRA) issues at jboss.org
Tue Jun 24 12:34:24 EDT 2014


    [ https://issues.jboss.org/browse/JBIDE-17672?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978993#comment-12978993 ] 

Andre Dietisheim edited comment on JBIDE-17672 at 6/24/14 12:33 PM:
--------------------------------------------------------------------

EGit CommitUI opens the EGit CommitDialog and then executes an EGit CommitJob. The job can be told to execute a push to upstream. "upstream" is either the remote that's configured to the repository or the current branch (.git/config : [branch "..."] remote = ...). There's no way in CommitJob to tell it to push to a programmatically specified remote. Another missing feature is the streaming of the git response while it comes in. 
I left the push operation (provided in CommitJob) alone and listen to the commit job successful termination. I then launch our own Push job.
This is meant as temporary solution, on the long run we should change EGit to allow the above requirements.


was (Author: adietish):
EGit CommitUI opens the EGit CommitDialog and then executes an EGit CommitJob. The job can be told to execute a push to upstream. "upstream" is either the remote that's configured to the repository or the current branch (.git/config : [branch "..."] remote = ...). There's no way in CommitJob to tell it to push to a programmatically specified remote. Another missing feature is the streaming of the git response while it comes in. 
I left the push operation (provided in CommitJob) alone and listen to the commit job successful termination. I then launch our own Push job.
This is meant as intermitent patching, we should change EGit to allow the above requirements.

> Contribute changes to EGit commit/push operation to allow our custom server adapter publishing 
> -----------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-17672
>                 URL: https://issues.jboss.org/browse/JBIDE-17672
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.2.0.Beta3
>            Reporter: Andre Dietisheim
>             Fix For: 4.2.x
>
>
> In JBIDE-10541 we made the EGit commit dialog come up before we publish the project to OpenShift. We did that by providing a modified copy of the EGit CommitUI class. We should contribute the changes that we did to CommitUI so that we can get rid of our copy. 
> When doing this we should also include streaming git responses to the Eclipse console as in Eclipse bug https://bugs.eclipse.org/bugs/show_bug.cgi?id=418653



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)


More information about the jbosstools-issues mailing list