[jbosstools-issues] [JBoss JIRA] (JBIDE-17464) Contacts mobile project example is not asking to use RedHat techrpeview maven repo

[Fred Bricon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17464?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12978228#comment-12978228 ] 

Fred Bricon edited comment on JBIDE-17464 at 6/30/14 5:08 AM:
--------------------------------------------------------------

I can see 3 approaches :
* add required_maven_dependencies fix : missing repo would appear in list of requirements instead of current behavior => UI inconsistency. Would also require special handling to load fixes from other plugins than org.jboss.tools.project.examples, to avoid dragging m2e dependencies in examples core. Meh
* new import type "maven+zip" : explicitly declares the example is *hybrid*, handles import in 2 steps. That means the day we add gradle support, we'll need gradle+zip. Meh.
* augment import type maven to import non-maven eclipse projects as well when listed in <includedProject>. Problem is ProjectExample definitions are mutated when they shouldn't (see https://github.com/jbosstools/jbosstools-central/blob/master/maven%2Fplugins%2Forg.jboss.tools.maven.project.examples%2Fsrc%2Forg%2Fjboss%2Ftools%2Fmaven%2Fproject%2Fexamples%2FImportMavenArchetypeProjectExampleDelegate.java#L53 for instance). A proper solution requires to split ProjectExample in a definition class and a working copy class. But that requires some non-trivial refactoring as I expressed before (see JBIDE-17713 ).

Other ideas?


was (Author: fbricon):
I can see 3 approaches :
* add required_maven_dependencies fix : missing repo would appear in list of requirements instead of current behavior => UI inconsistency. Would also require special handling to load fixes from other plugins than org.jboss.tools.project.examples, to avoid dragging m2e dependencies in examples core. Meh
* new import type "maven+zip" : explicitly declares the example is *hybrid*, handles import in 2 steps. That means the day we add gradle support, we'll need gradle+zip. Meh.
* augment import type maven to import non-maven eclipse projects as well when listed in <includedProject>. Problem is ProjectExample definitions are mutated when they shouldn't (see https://github.com/jbosstools/jbosstools-central/blob/master/maven%2Fplugins%2Forg.jboss.tools.maven.project.examples%2Fsrc%2Forg%2Fjboss%2Ftools%2Fmaven%2Fproject%2Fexamples%2FImportMavenArchetypeProjectExampleDelegate.java#L53 for instance). A proper solution requires to split ProjectExample in a definition class and a working copy class. But that requires some non-trivial refactoring as I expressed before.

Other ideas?

> Contacts mobile project example is not asking to use RedHat techrpeview maven repo
> ----------------------------------------------------------------------------------
>
>                 Key: JBIDE-17464
>                 URL: https://issues.jboss.org/browse/JBIDE-17464
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: project-examples
>    Affects Versions: 4.2.0.Beta2
>         Environment: JBDS 8.0.0.Beta2-v20140525-2146-B104
>            Reporter: Vlado Pakan
>            Assignee: Fred Bricon
>             Fix For: 4.2.0.Beta3
>
>
> 1. Import Mobile Applications > contacts-mobile-basic from JBoss Central without defined RedHat Tech preview All maven repo
> ERROR: Maven dependencies are not resolved for contacts-mobile-basic-services project and therefore project has many errors. User should be informed that he needs to define and use RedHat Tech preview All maven repo otherwise he will be unable to run this example



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)