[jbosstools-issues] [JBoss JIRA] (JBDS-3071) JBDS Installer shouldn't contain source features/plugins

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-3071?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12980740#comment-12980740 ] 

Nick Boldt edited comment on JBDS-3071 at 6/30/14 1:11 PM:
-----------------------------------------------------------

Actually, Central/EA sites do NOT contain jst.jsdt, but EA does include:
* Arquillian (and Sapphire)
* AngularJS (and Tern)
* VJET (and Jetty)

jst.jsdt is currently only in JBT afaict. So this too is an improvement.

New PR to remove things that were in the JBDS update site but which are not included in the installer:

https://github.com/jbdevstudio/jbdevstudio-product/pull/201

Removed items include:

* org.jboss.tools.vpe.cordovasim.feature (and source)
* org.jboss.tools.maven.jbosspackaging.feature (and source)
* org.jboss.tools.common.mylyn.feature (and source)

Problem w/ removing these is that the JBDS Central plugin.xml requirs all three of them in these connectors:

* JBoss Hybrid Mobile Tools + CordovaSim
* JBoss Tools Maven Packaging Configurator
* Mylyn support for reporting JBoss JIRAs and Red Hat Bugzillas

So if we remove them, then those connectors can't be installed in JBDS.

Possible workarounds:

a) do nothing and accept that for offline installs, you need the update site (not the installer) + central zip; also accept that the installer != update site

b) put these 3 features in the installer so that the installer contents == the update site contents (except for sources)

c) move these 3 features into the JBDS TP; this is bad because it creates an ugly dependency chain: JBDS -> JBDS TP -> JBT -> JBT TP... every time JBT rebuilds, we need to update the version of org.jboss.tools.* in the JBDS TP

d) move these 3 features into the Central TP; this is bad in that as in (c) we would have to keep updating the Central TP each time there's a new JBT release... but we already have this problem because of Arquillian being included in the EA TP.

So... I'd vote for (b) [easiest] or (d) [cleanest but requires more maintenance when we push out milestones]. 



was (Author: nickboldt):
Actually, Central/EA sites do NOT contain jst.jsdt, but EA does include:
* Arquillian (and Sapphire)
* AngularJS (and Tern)
* VJET (and Jetty)

jst.jsdt is currently only in JBT afaict. So this too is an improvement.

New PR to remove things that were in the JBDS update site but which are not included in the installer:

https://github.com/jbdevstudio/jbdevstudio-product/pull/201

Removed items include:

* org.jboss.tools.vpe.cordovasim.feature (and source)
* org.jboss.tools.maven.jbosspackaging.feature (and source)
* org.jboss.tools.common.mylyn.feature (and source)

> JBDS Installer shouldn't contain source features/plugins
> --------------------------------------------------------
>
>                 Key: JBDS-3071
>                 URL: https://issues.jboss.org/browse/JBDS-3071
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>      Security Level: Public(Everyone can see) 
>          Components: installer
>    Affects Versions: 8.0.0.Beta2
>            Reporter: Fred Bricon
>            Assignee: Nick Boldt
>             Fix For: 8.0.0.Beta3
>
>
> {quote}
> So the basic JBDS installer is 70MB fatter. From my understanding it's because we now ship a *huge* forge2 runtime (50MB), Tern, the JVM Monitor and probably some other minor stuff.
> Fair enough. But do we *really* need to add all the source features/plugins to the installer? *If* we're legally bound to provide sources for JBoss plugins, couldn't we provide them via an other way? (p2 only).
> I reckon we could save ~37 MB by not shipping sources in the installer. I know storage is cheap and d/l speeds are faster but that's not an excuse.
> {quote}



--
This message was sent by Atlassian JIRA
(v6.2.6#6264)