[jbosstools-issues] [JBoss JIRA] (JBIDE-16743) Sourcelookup does't work

[Snjezana Peco (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12952581#comment-12952581 ] 

Snjezana Peco edited comment on JBIDE-16743 at 3/13/14 6:04 AM:
----------------------------------------------------------------

The issue has been introduced by fixing JBIDE-14663 (https://github.com/fbricon/jbosstools-central/commit/a6a66974ab2b8ab91e07aa691464d651749628b4).

https://github.com/jbosstools/jbosstools-central/pull/115 ignores our source lookup for maven projects(see the description in JBIDE-14663).
However, the m2e source lookup won't work in the following two cases:

- if an artifact isn't included into the local maven repository (described in this jira)
- if an invalid source attachment already exists

Solution: 
- call our source lookup for a maven project too
or 
- contribute our source lookup to m2e

I think we would have to remove the Source Lookup dialog. M2e also adds a hardcoded source attachment so the dialog doesn't make sense. 
It could happen that we ask a user if he wants to add a source attachment, the user clicks "No", but, despite that, m2e adds it.
If a user opens some Java artifact, he certainly wants to open a source file, not a class file. It doesn't matter if our or m2e's source lookup will open it.
BTW if we want all the source files from a server are available when debugging the server, we also need to apply the PR from JBIDE-13851.

[~fbricon], [~maxandersen], 
Could you, please, comment on this?
                
      was (Author: snjeza):
    The issue has been introduced by fixing JBIDE-14663 (https://github.com/fbricon/jbosstools-central/commit/a6a66974ab2b8ab91e07aa691464d651749628b4).

https://github.com/jbosstools/jbosstools-central/pull/115 ignores our source lookup for maven projects(see the description in JBIDE-14663).
However, the m2e source lookup won't work in the following two cases:

- if an artifact isn't included into the local maven repository (described in this jira)
- if an invalid source attachment already exists

Solution: 
- call our source lookup for a maven project too
or 
- contribute our source lookup to m2e

I think we would have to remove the Source Lookup dialog. M2e also adds a hardcoded source attachment so the dialog doesn't make sense. 
It could happen that we ask a user if he wants to add a source attachment, the user clicks "No", but, despite that, m2e adds it.
If a user opens some Java artifact, he certainly wants to open a source file, not a class file. It doesn't matter if our or m2e's source lookup will open it.
BTW if we want all the source files from a server are available when debugging the server, we also need to apply the PR from JBIDE-13851.

                  
> Sourcelookup does't work
> ------------------------
>
>                 Key: JBIDE-16743
>                 URL: https://issues.jboss.org/browse/JBIDE-16743
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: maven
>    Affects Versions: 4.1.2.CR1
>            Reporter: Rastislav Wagner
>            Assignee: Snjezana Peco
>            Priority: Critical
>             Fix For: 4.2.0.Beta1
>
>
> Im trying source lookup on maven project according to http://screencast.com/t/i6k9hzkjViOs but when I open class file, nothing happens. 
> Sourcelookup works for non-maven project with mavenized libraries.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira