[jbosstools-issues] [JBoss JIRA] (JBIDE-16725) clean up jbosstools-maven-plugins/tycho-plugins/*

Nick Boldt (JIRA) issues at jboss.org
Wed Mar 26 09:47:15 EDT 2014


    [ https://issues.jboss.org/browse/JBIDE-16725?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12956572#comment-12956572 ] 

Nick Boldt commented on JBIDE-16725:
------------------------------------

I didn't merge it because I wanted your +1, [~mickael_istria]. Did you review it?
                
> clean up jbosstools-maven-plugins/tycho-plugins/*
> -------------------------------------------------
>
>                 Key: JBIDE-16725
>                 URL: https://issues.jboss.org/browse/JBIDE-16725
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>            Reporter: Nick Boldt
>            Assignee: Mickael Istria
>            Priority: Minor
>             Fix For: 4.2.0.Beta2
>
>
> A couple PRs/commits to clean stuff up, including:
> * deprecation warnings (Maven)
> * unused variables / imports (Eclipse)
> * copyright dates
> This one [1] was applied already, as it was a simple substitution:
> {code}
> [WARNING] org.jboss.tools.tycho.sitegenerator.GenerateRepositoryFacadeMojo#session:
> [WARNING]   The syntax
> [WARNING]     @parameter expression="${property}"
> [WARNING]   is deprecated, please use
> [WARNING]     @parameter property="property"
> [WARNING]   instead.
> {code}
> [1] https://github.com/jbosstools/jbosstools-maven-plugins/commit/eac10476e6572bd13fd0448bebd7173a6bb42fe9
> However, this one [2] was a bit more complicated as I switched from expression="" to default-value="" instead. Not sure if this is correct:
> [2] https://github.com/jbosstools/jbosstools-maven-plugins/pull/18

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators
For more information on JIRA, see: http://www.atlassian.com/software/jira


More information about the jbosstools-issues mailing list