[jbosstools-issues] [JBoss JIRA] (JBIDE-16517) SSL Certificate dialog: need to show to what server we're connecting

[Andre Dietisheim (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-16517?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12967278#comment-12967278 ] 

Andre Dietisheim edited comment on JBIDE-16517 at 5/12/14 2:32 PM:
-------------------------------------------------------------------

[~dazarov] sorry did not see your question, I missed it on my radar somehow. #getRecentConnection() is the correct host only if this was the last connection that was used in UI. The callback that present the dialog though is triggered by the openshift-java-client. I would rather try to enhance openshift-java-client to report the host in the callback interface. The problem is that the callback wont unveil the host so far, it only has the X509Certificates chain:

{code}
public interface ISSLCertificateCallback {
	public boolean allowCertificate(X509Certificate[] chain);
	public boolean allowHostname(String hostname, SSLSession session); 
}
{code}


was (Author: adietish):
[~dazarov] sorry did not see your question, went unnoticed on my radar. #getRecentConnection() is the correct host only if this was the last connection that was used. Some change in the Connections model (maybe unintentional and we dont have the right connection any more. I would rather try to enhance openshift-java-client to report the host since the library knows what host we're connecting. The problem is that the callback that's used to trigger this wont unveil the host so far, it only has the X509Certificates chain:

{code}
public interface ISSLCertificateCallback {
	public boolean allowCertificate(X509Certificate[] chain);
	public boolean allowHostname(String hostname, SSLSession session); 
}
{code}

> SSL Certificate dialog: need to show to what server we're connecting
> --------------------------------------------------------------------
>
>                 Key: JBIDE-16517
>                 URL: https://issues.jboss.org/browse/JBIDE-16517
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.2.0.Alpha1
>            Reporter: Andre Dietisheim
>              Labels: connection_wizard
>             Fix For: 4.2.0.CR1
>
>         Attachments: certificate-dialog.png
>
>   Original Estimate: 1 day
>  Remaining Estimate: 1 day
>
> The current dialog does not show explicitly to what server we're talking:
> !certificate-dialog.png!
> We should add some text like
> ...untrusted SSL certificate *presented by server <server-url>*



--
This message was sent by Atlassian JIRA
(v6.2.3#6260)