[jbosstools-issues] [JBoss JIRA] (JBIDE-18747) NPE in CDI (probably) Validation

[Victor Rubezhny (JIRA)]

Victor Rubezhny created JBIDE-18747:
---------------------------------------

             Summary: NPE in CDI (probably) Validation
                 Key: JBIDE-18747
                 URL: https://issues.jboss.org/browse/JBIDE-18747
             Project: Tools (JBoss Tools)
          Issue Type: Bug
          Components: cdi, jsp/jsf/xml/html source editing
    Affects Versions: 4.2.0.Final
            Reporter: Victor Rubezhny


In some cases, when you're editing HTML Validation Preferences and agree to perform a build on pressing 'Apply' and then immediately do the same on pressing 'OK' button, an NPE occurs in Validation:

{code}
!ENTRY org.jboss.tools.common 4 0 2014-11-13 02:17:31.326
!MESSAGE 
!STACK 0
org.jboss.tools.common.validation.JBTValidationException
	at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:123)
	at org.jboss.tools.common.validation.ValidatorManager.validateInJob(ValidatorManager.java:81)
	at org.eclipse.wst.validation.internal.core.ValidatorLauncher.start(ValidatorLauncher.java:77)
	at org.eclipse.wst.validation.Validator$V1.validate(Validator.java:768)
	at org.eclipse.wst.validation.Validator.validate(Validator.java:405)
	at org.eclipse.wst.validation.internal.ValManager.validate(ValManager.java:704)
	at org.eclipse.wst.validation.internal.ValManager$1.visit(ValManager.java:665)
	at org.eclipse.wst.validation.internal.ValManager.accept(ValManager.java:783)
	at org.eclipse.wst.validation.internal.ValManager.validate(ValManager.java:669)
	at org.eclipse.wst.validation.internal.ValidationRunner.execute(ValidationRunner.java:134)
	at org.eclipse.wst.validation.internal.ValidationRunner.run(ValidationRunner.java:148)
	at org.eclipse.core.internal.resources.Workspace.run(Workspace.java:2313)
	at org.eclipse.wst.validation.internal.ValidationRunner.validate(ValidationRunner.java:67)
	at org.eclipse.wst.validation.ValidationFramework.validate(ValidationFramework.java:661)
	at org.eclipse.wst.sse.ui.internal.preferences.ui.AbstractValidationSettingsPage$ValidateJob.run(AbstractValidationSettingsPage.java:411)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
Caused by: java.lang.NullPointerException
	at org.jboss.tools.common.validation.ValidatorManager.validate(ValidatorManager.java:116)
	... 15 more
{code}

Some debugging shows that NPE happens when validator is CDICoreValidator object: the following expression: 
{code}validationHelper.getValidationContextManager().getValidatingProjectTree(validator){code}, and that value is used with no any checks for that.



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)