[jbosstools-issues] [JBoss JIRA] (JBIDE-18742) Use p2diff to determine whether to publish new aggregate

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18742?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021074#comment-13021074 ] 

Mickael Istria commented on JBIDE-18742:
----------------------------------------

I've succeedeed to write a good draft of what we want in  jbosstools-build-sites.aggregate.coretests-site_master
{code:bash}
if [[ "$forcePublish" = "true" ]]; then
  echo "Will publish: forcePublish set to true"
  publish=true
fi

#alias p2diff=/home/mistria/p2diff/org.eclipse.equinox.p2.example.p2diff.packaging/target/products/org.eclipse.equinox.p2.example.p2diff.product/linux/gtk/x86_64/p2diff
/home/mistria/p2diff/org.eclipse.equinox.p2.example.p2diff.packaging/target/products/org.eclipse.equinox.p2.example.p2diff.product/linux/gtk/x86_64/p2diff file:${WORKSPACE}/sources/aggregate/site/target/repository/ http://download.jboss.org/jbosstools/builds/staging/${JOB_NAME}/all/repo/ | grep -e ^\< -e ^\> > p2diff_snapshot
if [[ -s p2diff_snapshot ]]; then 
  echo "Will publish: p2diff detected changes"
  publish=true
fi

cd ${WORKSPACE}/sources/
wget https://raw.github.com/jbosstools/jbosstools-build-ci/master/publish/publish.sh -q --no-check-certificate -N
if [[ "$publish" = "true" ]]; then
  export skipRevisionCheckWhenPublishing=true #Condition should be externalized, like p2diff, to control value of "$publish"
  . publish.sh coretests/trunk
else 
  export skipRevisionCheckWhenPublishing=${skipRevisionCheckWhenPublishing}
  . publish.sh coretests/trunk
fi

mv ${WORKSPACE}/sources/aggregate/site ${WORKSPACE}/sources/aggregate/coretests-site
mv ${WORKSPACE}/sources/aggregate/site_BAK ${WORKSPACE}/sources/aggregate/site  
{code}

Goal is to separate 2 steps:
# Check whether we need/want to publish
# actually publish

It would be cool if we could move the part that check for SCM changes to part 1. I believe the scripts will have to go in 2 files: checkPubish.sh and doPublish.sh.

> Use p2diff to determine whether to publish new aggregate
> --------------------------------------------------------
>
>                 Key: JBIDE-18742
>                 URL: https://issues.jboss.org/browse/JBIDE-18742
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>            Reporter: Mickael Istria
>
> Instead of the composite-install test to decide whether we aggregate or not, it would be simpler to build aggregation in any case and then use p2diff (or other smart mechanism) to decide whether we want to publish the new composite or not.
> It's more or less just a matter of scripting
> {code:none}
> p2diff file:${WORKSPACE}/results/${JOB_NAME}/all/repo/ http://download.jboss.org/jbosstools/builds/staging/${JOB_NAME}/all/repo/ | grep -e ^\< -e ^\> > p2diff_snapshot
> if [[ -s p2diff_snapshot ]]; then
>    ./publish.sh
> fi
> {code}
> Another benefit is that it allows us to get rid of the composite (1 less couple of files to maintain)



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)