[jbosstools-issues] [JBoss JIRA] (JBIDE-18772) Include publish.sh in parent pom as versioned maven dependency

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18772?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021592#comment-13021592 ] 

Mickael Istria commented on JBIDE-18772:
----------------------------------------

Because many jobs reference URL to the master branch for publish.sh and because publish.sh itself references other scripts in master branch ( https://github.com/jbosstools/jbosstools-build-ci/blob/master/publish/publish.sh#L743 ), then it seems quite risky to try non-backward compatible change on master branch.
IMO, the best thing is to leave 4.2 jobs and master branch "as it" for now, and start by focusing on 4.3.
I suggest that we create another "main" branch where to start working on making those scripts more standalone, available as Maven artifacts and cleaner. What about calling this branch "4.3.x" ?

I updated my PR (#116) so that all related scripts are bundled into a same zip (this is necessary for example because publish.sh depends on jbosstools-cleanup.sh), and jobs can get the necessary scripts to publish by running
{code}
mvn org.apache.maven.plugins:maven-dependency-plugin:2.9:unpack -Dartifact=org.jboss.tools.releng:publish:4.3.0.Alpha1-SNAPSHOT:zip:publish -DoutputDirectory=. -DtrimVersion=true -Dmdep.stripClassifier=true -Dmdep.stripVersion=true
{code}

> Include publish.sh in parent pom as versioned maven dependency
> --------------------------------------------------------------
>
>                 Key: JBIDE-18772
>                 URL: https://issues.jboss.org/browse/JBIDE-18772
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: build
>            Reporter: Max Rydahl Andersen
>            Assignee: Mickael Istria
>
> instead of relying to publish.sh being on master, we should use a versioned publish.sh (or maybe even mojo) that the build then uses.
> suggestion:
> publish.sh (or mojo) gets released to our maven repo, use it in the pom.xml to perform publishing.
> What this helps with is:
> a) can do changes to publish mechanism without affecting every past builds.
> b) more movable build system
> c) isolated testing possible 
>  



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)