[jbosstools-issues] [JBoss JIRA] (JBIDE-18794) Move shared properties related to JRE paths and itest.skip into parent pom

Rob Stryker (JIRA) issues at jboss.org
Thu Nov 20 10:16:39 EST 2014


    [ https://issues.jboss.org/browse/JBIDE-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13021636#comment-13021636 ] 

Rob Stryker commented on JBIDE-18794:
-------------------------------------

The itest profile should do nothing really except set itest.skip=false   and  skipPrivateRequirements=false.    There's no legitimate other work that needs to be done here. 

Each test plugin should still be in charge of setting its own surefire timeouts, since that differs based on the component. 

The following properties need to be declared in parent pom:

{code}
		<jbosstools.test.jre.5></jbosstools.test.jre.5>
		<jbosstools.test.jre.6></jbosstools.test.jre.6>
		<jbosstools.test.jre.7></jbosstools.test.jre.7>
		<jbosstools.test.jre.8></jbosstools.test.jre.8>
{code}

The properties should be declared as blank by default, and should be filled in with correct values for the hudson profile. Users can still override based on their own -D arguments. The reason these must be declared as blank is because if they are undeclared, many tests will misunderstand the string "${jbosstools.test.jre.7}" to be a location on disk and fail in various unique ways. It is much better to set them to blank (and thus null, as far as the tests are concerned)  while having the hudson profile fill in accurate values. 

> Move shared properties related to JRE paths and itest.skip into parent pom
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-18794
>                 URL: https://issues.jboss.org/browse/JBIDE-18794
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build, server
>    Affects Versions: 4.3.0.Alpha1
>            Reporter: Nick Boldt
>             Fix For: 4.3.0.Alpha1
>
>
> Some properties (and maybe the -Pitest profile) in the root of jbosstools-server can eventually be moved into the parent pom for reuse by other projects.
> (This was suggested by Max to Rob at some point on 2014/11/20.)



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)


More information about the jbosstools-issues mailing list