[jbosstools-issues] [JBoss JIRA] (JBIDE-18794) Move shared properties related to JRE paths and itest.skip into parent pom

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18794?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13022748#comment-13022748 ] 

Max Rydahl Andersen commented on JBIDE-18794:
---------------------------------------------

Yes, none of this was *declared* by me. it was found by collaboration between Rob and I to find the best default. 

Mickael says it is good to have "skips" be default false; I think that depends on the situation. For things related to what tests are run I definitely think it is good to have it be false.  But we actually have skipPrivateRequirements default to true because most wont actually have vpn access; I can also see that skipSigning is in here - but that might just be leftovers since signing actually never been used in production.

I've left comments in the PR on making the docs/comments a bit more clear/specific.

> Move shared properties related to JRE paths and itest.skip into parent pom
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-18794
>                 URL: https://issues.jboss.org/browse/JBIDE-18794
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: build, server
>    Affects Versions: 4.3.0.Alpha1
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>             Fix For: 4.3.0.Alpha1
>
>
> Some properties (and maybe the -Pitest profile) in the root of jbosstools-server can eventually be moved into the parent pom for reuse by other projects.
> (This was suggested by Max to Rob at some point on 2014/11/20.)



--
This message was sent by Atlassian JIRA
(v6.3.8#6338)