[jbosstools-issues] [JBoss JIRA] (JBIDE-3355) org.jboss.tools.common.text.ext.hyperlink.AbstractHyperlink review

[Denis Golovin (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-3355?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Denis Golovin closed JBIDE-3355.
--------------------------------


> org.jboss.tools.common.text.ext.hyperlink.AbstractHyperlink review
> ------------------------------------------------------------------
>
>                 Key: JBIDE-3355
>                 URL: https://issues.jboss.org/browse/JBIDE-3355
>             Project: Tools (JBoss Tools)
>          Issue Type: Sub-task
>          Components: cleanup
>    Affects Versions: 3.0.0.cr1
>            Reporter: Denis Golovin
>            Assignee: Denis Golovin
>
> 1. Consider using another approach instead of using snippet below in all methods:
> 	protected IFile getFile() {
> 		StructuredModelWrapper smw = new StructuredModelWrapper();
> 		try {
> 			smw.init(getDocument());
> 			return smw.getFile();
> 		} finally {
> 			smw.dispose();
> 		}
> 	}
> 2. Review static methods, as example - public static IFile getFile(IStructuredModel structuredModel) looks to compex



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)