[jbosstools-issues] [JBoss JIRA] (JBDS-3187) enforce rule that JBDS com.jboss.* bits must have GA, not Final qualifier

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-3187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13013062#comment-13013062 ] 

Nick Boldt commented on JBDS-3187:
----------------------------------

Why hurry? Because master branch is safe for fresh commits. "Why wait?" is a better question. This hurts no one.

It's dead simple to change the way the enforcer works - it's just a line or two of java. So if you don't want to check the parent pom's version, we could just check 

{code}
if ( this.shouldIfail && BUILD_ALIAS.equals("Final"))
{
  throw new EnforcerRuleException( " ** Parent pom version ("+parentVersion+") contains .Final; must set -DBUILD_ALIAS=GA **");
}
{code}


> enforce rule that JBDS com.jboss.* bits must have GA, not Final qualifier
> -------------------------------------------------------------------------
>
>                 Key: JBDS-3187
>                 URL: https://issues.jboss.org/browse/JBDS-3187
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Task
>          Components: build
>    Affects Versions: 8.0.0.CR2
>            Reporter: Nick Boldt
>            Assignee: Nick Boldt
>
> Add a custom enforcer rule (using org.apache.maven.enforcer.rule) that will check if the parent pom contains .Final, and if so, will fail the build unless BUILD_ALIAS is set to "GA".



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)