[jbosstools-issues] [JBoss JIRA] (JBIDE-18260) cannot open properties pages for a launch because of tern NPE'ing

[Victor Rubezhny (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18260?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=12999293#comment-12999293 ] 

Victor Rubezhny commented on JBIDE-18260:
-----------------------------------------

Not sure why this certain page is being created when you're opening properties, but Eclipse needs to create the contents of pages before it can show Preferences dialog. This certain page requires a resource for its correct work, but actually can be loaded without any resource (it will not show its fields in this case). So, the absence of null-check in content creation has lead to the fail.

I'll check what we can do to prevent the page from loading when requesting properties when there is no resource given.





> cannot open properties pages for a launch because of tern NPE'ing
> -----------------------------------------------------------------
>
>                 Key: JBIDE-18260
>                 URL: https://issues.jboss.org/browse/JBIDE-18260
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: jsp/jsf/xml/html source editing
>            Reporter: Max Rydahl Andersen
>            Assignee: Victor Rubezhny
>            Priority: Critical
>             Fix For: 4.2.0.CR1
>
>
> I launch JBoss, then go under Debug to find the process to see the parameters and I get a blank page saying there are invalid values.
> In error log is this:
> {code}
> java.lang.NullPointerException
> 	at tern.eclipse.ide.ui.properties.TernModulesPropertyPage.createContents(TernModulesPropertyPage.java:62)
> 	at org.eclipse.jface.preference.PreferencePage.createControl(PreferencePage.java:233)
> 	at org.eclipse.jface.preference.PreferenceDialog.createPageControl(PreferenceDialog.java:1537)
> 	at org.eclipse.jface.preference.PreferenceDialog$13.run(PreferenceDialog.java:1289)
> 	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> 	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
> 	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:178)
> 	at org.eclipse.jface.preference.PreferenceDialog.showPage(PreferenceDialog.java:1281)
> 	at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.showPage(FilteredPreferenceDialog.java:699)
> 	at org.eclipse.jface.preference.PreferenceDialog$9$1.run(PreferenceDialog.java:730)
> 	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
> 	at org.eclipse.jface.preference.PreferenceDialog$9.selectionChanged(PreferenceDialog.java:725)
> 	at org.eclipse.jface.viewers.StructuredViewer$3.run(StructuredViewer.java:876)
> 	at org.eclipse.core.runtime.SafeRunner.run(SafeRunner.java:42)
> 	at org.eclipse.ui.internal.JFaceUtil$1.run(JFaceUtil.java:50)
> 	at org.eclipse.jface.util.SafeRunnable.run(SafeRunnable.java:178)
> 	at org.eclipse.jface.viewers.StructuredViewer.firePostSelectionChanged(StructuredViewer.java:873)
> 	at org.eclipse.jface.viewers.StructuredViewer.setSelection(StructuredViewer.java:1708)
> 	at org.eclipse.jface.viewers.TreeViewer.setSelection(TreeViewer.java:1093)
> 	at org.eclipse.jface.preference.PreferenceDialog.selectSavedItem(PreferenceDialog.java:1083)
> 	at org.eclipse.ui.internal.dialogs.FilteredPreferenceDialog.selectSavedItem(FilteredPreferenceDialog.java:757)
> 	at org.eclipse.jface.preference.PreferenceDialog$4.run(PreferenceDialog.java:390)
> 	at org.eclipse.swt.custom.BusyIndicator.showWhile(BusyIndicator.java:70)
> 	at org.eclipse.jface.preference.PreferenceDialog.createContents(PreferenceDialog.java:385)
> 	at org.eclipse.jface.window.Window.create(Window.java:435)
> 	at org.eclipse.jface.dialogs.Dialog.create(Dialog.java:1101)
> 	at org.eclipse.ui.internal.dialogs.PropertyDialog.createDialogOn(PropertyDialog.java:83)
> 	at org.eclipse.ui.dialogs.PropertyDialogAction.createDialog(PropertyDialogAction.java:177)
> 	at org.eclipse.ui.dialogs.PropertyDialogAction.run(PropertyDialogAction.java:158)
> 	at org.eclipse.jface.action.Action.runWithEvent(Action.java:519)
> 	at org.eclipse.jface.action.ActionContributionItem.handleWidgetSelection(ActionContributionItem.java:595)
> 	at org.eclipse.jface.action.ActionContributionItem.access$2(ActionContributionItem.java:511)
> 	at org.eclipse.jface.action.ActionContributionItem$5.handleEvent(ActionContributionItem.java:420)
> 	at org.eclipse.swt.widgets.EventTable.sendEvent(EventTable.java:84)
> 	at org.eclipse.swt.widgets.Display.sendEvent(Display.java:4188)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1467)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1490)
> 	at org.eclipse.swt.widgets.Widget.sendEvent(Widget.java:1475)
> 	at org.eclipse.swt.widgets.Widget.notifyListeners(Widget.java:1279)
> 	at org.eclipse.swt.widgets.Display.runDeferredEvents(Display.java:4031)
> 	at org.eclipse.swt.widgets.Display.readAndDispatch(Display.java:3658)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine$9.run(PartRenderingEngine.java:1151)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.e4.ui.internal.workbench.swt.PartRenderingEngine.run(PartRenderingEngine.java:1032)
> 	at org.eclipse.e4.ui.internal.workbench.E4Workbench.createAndRunUI(E4Workbench.java:148)
> 	at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:636)
> 	at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:332)
> 	at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:579)
> 	at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
> 	at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:135)
> 	at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
> 	at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:382)
> 	at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:236)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
> 	at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
> 	at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
> 	at java.lang.reflect.Method.invoke(Method.java:606)
> 	at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
> 	at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
> 	at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
> {code}



--
This message was sent by Atlassian JIRA
(v6.3.1#6329)