[jbosstools-issues] [JBoss JIRA] (JBIDE-18328) NPE in VpvDefaultTemplate

Fri Sep 12 17:32:19 EDT 2014

    [ https://issues.jboss.org/browse/JBIDE-18328?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13002077#comment-13002077 ] 

Viacheslav Kabanovich edited comment on JBIDE-18328 at 9/12/14 5:32 PM:
------------------------------------------------------------------------

[~kmarmaliykov], then, maybe I found another bug. If html does not have <html> and <body> tags, but just contains several first level tags, then taking single document element shows only first section of content, while browsers show the entire content. I think that may be of value for Ionic templates. Please consider if this should be fixed.

was (Author: scabanovich):
[~kmarmaliykov], then, maybe I found another bug. If html does not have <html> and <body> tags, but justs contains several first level tags, then taking single document element shows only first section of content, while browsers show the entire content. Please consider if this should be fixed.

> NPE in VpvDefaultTemplate
> -------------------------
>
>                 Key: JBIDE-18328
>                 URL: https://issues.jboss.org/browse/JBIDE-18328
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: visual-page-editor-core
>    Affects Versions: 4.2.0.Beta3
>            Reporter: Viacheslav Kabanovich
>            Assignee: Konstantin Marmalyukov
>             Fix For: 4.2.0.CR1
>
>
> Create html file with text
> {code}
> <!doctype html>
> {code}
> Close editor and open file in JBoss Tools HTML Editor.
> Failure: 
> Exception in thread "Thread-17" java.lang.NullPointerException
> 	at org.jboss.tools.vpe.preview.core.template.VpvDefaultTemplate.create(VpvDefaultTemplate.java:32)
> 	at org.jboss.tools.vpe.preview.core.transform.VpvDomBuilder.convertNode(VpvDomBuilder.java:84)
> 	at org.jboss.tools.vpe.preview.core.transform.VpvDomBuilder.buildVisualModel(VpvDomBuilder.java:48)
> 	at org.jboss.tools.vpe.preview.core.transform.VpvController.getResource(VpvController.java:60)
> 	at org.jboss.tools.vpe.preview.core.server.VpvSocketProcessor.processRequest(VpvSocketProcessor.java:83)
> 	at org.jboss.tools.vpe.preview.core.server.VpvSocketProcessor.run(VpvSocketProcessor.java:68)
> 	at java.lang.Thread.run(Thread.java:722)
> In this case source dom document is not null, but its document element is null. The check (sourceDocument != null) in VpvController passes, and then VpvDomBuilder.buildVisualModel() does not check documentElement for null.

--
This message was sent by Atlassian JIRA
(v6.3.1#6329)