[jbosstools-issues] [JBoss JIRA] (JBIDE-19410) earlyaccess still not failing gracefully

[Mickael Istria (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19410?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13057225#comment-13057225 ] 

Mickael Istria edited comment on JBIDE-19410 at 4/9/15 4:39 AM:
----------------------------------------------------------------

{quote}Mickael, considering your last change related to wrapping updateTitle(heading) inside display.asyncExec() you never ran the actual code, did you? {quote}
I have to admit I didn't try the last patch before pushing ;) But I just gave it a try now, and it's working fine on my machine. What did you find wrong? I'm just changing the asyncExec by a syncExec because async in an (async) job is too much async.
The root cause of this failure are explained in previous comments (mainly #2 and #8). This is a corner-case of using PDE Launch Configuration without p2 enabled, such issue doesn't exist in real package and the change is actually just some "powder" to hide the fact that dev-mode doesn't support p2 by default. Since this doesn't happen in "real-life", I don't think we need more effort regarding messages.
If you want to fully try the Central functionality in dev-mode, you have to tweak your PDE Launch Configuration to enable p2, as explained in comment #2.


was (Author: mickael_istria):
{quote}Mickael, considering your last change related to wrapping updateTitle(heading) inside display.asyncExec() you never ran the actual code, did you? {quote}
I have to admit I didn't try the last patch ;) But I just gave it a try now, and it's working fine on my machine. What did you find wrong? I'm just changing the asyncExec by a syncExec because async in an (async) job is too much async.
The root cause of this failure are explained in previous comments (mainly #2 and #8). This is a corner-case of using PDE Launch Configuration without p2 enabled, such issue doesn't exist in real package and the change is actually just some "powder" to hide the fact that dev-mode doesn't support p2 by default. Since this doesn't happen in "real-life", I don't think we need more effort regarding messages.
If you want to fully try the Central functionality in dev-mode, you have to tweak your PDE Launch Configuration to enable p2, as explained in comment #2.

> earlyaccess still not failing gracefully
> ----------------------------------------
>
>                 Key: JBIDE-19410
>                 URL: https://issues.jboss.org/browse/JBIDE-19410
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central
>            Reporter: Max Rydahl Andersen
>            Assignee: Mickael Istria
>            Priority: Minor
>             Fix For: 4.3.0.Alpha2
>
>
> start jboss tools in PDE and earlyaccess will pop up with error dialog that it had an error because it could not install things (which is expected when running in PDE)
> start jboss tools without network access and I sometime see it pop up - can't reprouce that consistently.
> but in short - seems like earlyaccess continues to want to tell users that something is wrong with early access even when it is not enabled but nor should it even if enabled. Show such error on the earlyaccess page rather than a blocking dialog.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)