[jbosstools-issues] [JBoss JIRA] (JBIDE-18752) Freemarker plugin does not work for square bracket (since JBT 4.2.0.Final)

[Miroslav Zaťko (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18752?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059168#comment-13059168 ] 

Miroslav Zaťko edited comment on JBIDE-18752 at 4/15/15 5:12 AM:
-----------------------------------------------------------------

Crashes, no colours and weird keyboard input responses as [~matteo.pelucco] wrote has nothing to do with ftl at the beginning of template.
It happens all the time regardless of ftl at the beginning, regardless of square brackets, angle brackets, regardless of anything... Only way how to reduce it a bit is saving to disk really often... Maybe after each character input...
This is why I removed the plugin...


was (Author: mirec.zatko):
Crashes, no colours and weird keyboard input responses as [~matteo.pelucco] wrote has nothing to do with ftl at the beginning of template.
It happens all the time regardless of ftl at the beginning, regardless of square brackets, angle brackets, regardless of anything... Only way how to reduce it a bit is to saving to disk really often... Maybe after each character input...
This is why I removed the plugin...

> Freemarker plugin does not work for square bracket (since JBT 4.2.0.Final)
> --------------------------------------------------------------------------
>
>                 Key: JBIDE-18752
>                 URL: https://issues.jboss.org/browse/JBIDE-18752
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: freemarker
>    Affects Versions: 4.2.0.Final
>            Reporter: Denis Golovin
>            Assignee: Max Rydahl Andersen
>             Fix For: 4.3.0.Alpha2
>
>
> From https://github.com/jbosstools/jbosstools-freemarker/issues/26
> {quote}
> When using the plugin to edit freemarker files that use the square bracket syntax the editor fails to highlight the syntax (this is happening in JBoss Tools 4.20 Final).
> I think the file: src / org / jboss / ide / eclipse / freemarker / editor / DocumentProvider.java
> on line 70 is causing the syntax highlighting problem:
> {code}if (ch != LexicalConstants.SQUARE_SYNTAX_MARKER.charAt(i)) { 
>         return SyntaxMode.ANGLE; 
> }
> SQUARE_SYNTAX_MARKER.charAt(i) 
> {code}
> It should start in 0 and have a different index than i (the index of the file content) to have a proper string matching. Also, SQUARE_SYNTAX_MARKER is [#ftl, not all files start with a ftl tag, so I don't see the need for "ftl" at the end, so that's why in the following example fix I put j < 2.
> e.g.
> {code}
> int j =0;
> for (; i < docLength && j < 2; i++) { 
>     char ch = document.getChar(i); 
>     if (ch != LexicalConstants.SQUARE_SYNTAX_MARKER.charAt(j)) { 
>         return SyntaxMode.ANGLE; 
>     } 
>        j++;
> } 
> {code}
> {quote}



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)