[jbosstools-issues] [JBoss JIRA] (JBIDE-18460) 'Add type to deployment' quickfix doesn't work with abstract classes

[Aslak Knutsen (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18460?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13059876#comment-13059876 ] 

Aslak Knutsen edited comment on JBIDE-18460 at 4/16/15 3:49 PM:
----------------------------------------------------------------

When complaining about missing type, detect if there is a super class with a @Deployment method... 

A test class/ hierarchy can have multiple Deployment methods (with different names), so the scenario is not wrong. Tooling should detect super classes and suggest which scope do you want to create the Deployment.. In a class hierarchy the Deployment method generation can have multiple targets (current class or super class), depending on the chosen target and if it has a Deployment method already the missing classes should be added or a method created.


was (Author: aslak):
When complaining about missing type, detect if there is a super class with a @Deployment method... 

A test class/ hierarchy can have multiple Deployment methods (with different names), so the scenario is not wrong. Tooling should detect super classes and suggest which scope do you want to create the Deployment..

> 'Add type to deployment' quickfix doesn't work with abstract classes
> --------------------------------------------------------------------
>
>                 Key: JBIDE-18460
>                 URL: https://issues.jboss.org/browse/JBIDE-18460
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: arquillian, upstream
>    Affects Versions: 4.2.0.CR1
>            Reporter: Snjezana Peco
>            Assignee: Snjezana Peco
>             Fix For: 4.3.x
>
>
> Steps to reproduce:
> - create an abstract Arquillian JUnit test with a deployment method
> - create an Arquillian JUnit test extending the previous created abstract class
> - add a type not included in the deployment method to the test created in the step 2 
> The "Type is not included in any deployment" marker will be created properly
> - call the "Add type to deployment" quickfix 
> You will get the "Cannot find a deployment method" dialog.



--
This message was sent by Atlassian JIRA
(v6.3.11#6341)