[jbosstools-issues] [JBoss JIRA] (JBIDE-19645) Remove seam 3 features from JBDS, JBT default install; add new connector to Central

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19645?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061543#comment-13061543 ] 

Nick Boldt edited comment on JBIDE-19645 at 4/22/15 10:11 AM:
--------------------------------------------------------------

org.jboss.tools.cdi.seam.feature, org.jboss.tools.cdi.seam.core, org.jboss.tools.cdi.core and org.jboss.tools.cdi.seam.core.test *DO* use the phrase "Seam 3":

{code:title=https://github.com/jbosstools/jbosstools-javaee/blob/master/cdi/features/org.jboss.tools.cdi.seam.feature/feature.properties#L1-L8}
featureName=Seam 3 Tools
description=Seam 3 Tools provides tooling for the CDI components released as part of Seam 3 modules such as Solder and Config. Tooling covers recognizing these CDI components and editing the seam config xml. 
{code}

If all you want is that we rename the features to remove "Seam 3", that's doable too.

How would you change other 4 occurrences? 

{code}
**  ./cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/BeanMember.java ** 
127-	 * These method is used to construct fake members that get all 
128-	 * annotations from this member, but should have another type;
129:	 * e.g. in implementation of Seam 3 persistence extension.
130-	 * @param d
131-	 */

**  ./cdi/plugins/org.jboss.tools.cdi.seam.core/META-INF/MANIFEST.MF ** 
3:Bundle-Name: Seam 3 Core

**  ./cdi/plugins/org.jboss.tools.cdi.seam.core/src/org/jboss/tools/cdi/seam/core/CDISeamCorePlugin.java ** 
25:	// Seam 3 International Module Runtime Extension ID

** ./cdi/tests/org.jboss.tools.cdi.seam.core.test/META-INF/MANIFEST.MF ** 
3:Bundle-Name: Seam 3 Core Test
{code}


was (Author: nickboldt):
org.jboss.tools.cdi.seam.feature, org.jboss.tools.cdi.seam.core, org.jboss.tools.cdi.core and org.jboss.tools.cdi.seam.core.test *DO* use the phrase "Seam 3":

{code:title=https://github.com/jbosstools/jbosstools-javaee/blob/master/cdi/features/org.jboss.tools.cdi.seam.feature/feature.properties#L1-L8}
featureName=Seam 3 Tools
description=Seam 3 Tools provides tooling for the CDI components released as part of Seam 3 modules such as Solder and Config. Tooling covers recognizing these CDI components and editing the seam config xml. 
{code}

If all you want is that we rename the features to remove "Seam 3", that's doable too.

How would you change other 4 occurrences? 

**  ./cdi/plugins/org.jboss.tools.cdi.core/src/org/jboss/tools/cdi/internal/core/impl/BeanMember.java ** 
127-	 * These method is used to construct fake members that get all 
128-	 * annotations from this member, but should have another type;
129:	 * e.g. in implementation of Seam 3 persistence extension.
130-	 * @param d
131-	 */

**  ./cdi/plugins/org.jboss.tools.cdi.seam.core/META-INF/MANIFEST.MF ** 
3:Bundle-Name: Seam 3 Core

**  ./cdi/plugins/org.jboss.tools.cdi.seam.core/src/org/jboss/tools/cdi/seam/core/CDISeamCorePlugin.java ** 
25:	// Seam 3 International Module Runtime Extension ID

** ./cdi/tests/org.jboss.tools.cdi.seam.core.test/META-INF/MANIFEST.MF ** 
3:Bundle-Name: Seam 3 Core Test


> Remove seam 3 features from JBDS, JBT default install; add new connector to Central
> -----------------------------------------------------------------------------------
>
>                 Key: JBIDE-19645
>                 URL: https://issues.jboss.org/browse/JBIDE-19645
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: central, seam2, updatesite
>    Affects Versions: 4.3.0.Alpha2
>            Reporter: Nick Boldt
>            Assignee: Alexey Kazakov
>             Fix For: 4.3.0.Beta1
>
>
> Burr has requested we also remove Seam 3. So I've assumed we'll do it the same way we did for Seam 2:
> * remove from CoreTools categories on update sites
> * remove from JBDS core.feature
> * create new connectors in JBT and JBDS Central
> [~burrsutter] [~maxandersen] please confirm this is the path you want taken for all the renaming features with "seam" in their name.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)