[jbosstools-issues] [JBoss JIRA] (JBDS-3191) Improve the way we switch between development and GA

[Max Rydahl Andersen (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-3191?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13061794#comment-13061794 ] 

Max Rydahl Andersen commented on JBDS-3191:
-------------------------------------------

except jboss.discovery.site.url is *NOT* that site in example https://github.com/jbosstools/jbosstools-download.jboss.org/blob/master/jbosstools/configuration/ide-config.properties#L23-L24

it is also not enough to have us just take jboss.discovery.site.url and add. there need to be a separate property to enable that "hey - please add this to the list of updates" and likewise "hey - please remove these" 

Thus the plugin side need to have a separate property to "trigger" this feature i.e. .development.enabled=true which instructs our plugins to look at .development.sites 
for updatesites to add.

For example:
{code}
.development.enabled=true
.development.sites=${jboss.discovery.site.url}
{code}

This means please go add list of sites in .development.sites to user p2 sites (we should ask user first time for this I think)

This gives you what you want (reusing the property value) but does not mix up and cause overlap of concerns.

Then the flipside is that when development is no longer active, we need the inverse, i.e.

{code}
.development.enabled=false
.development.sites=https://devstudio.redhat.com/9.0/development/updates/
{code}

This tells us to check if the sites listed in .development.sites are available if no nothing happens, if they are we tell the user
the development phase is over and whether he wants to remove these sites.

Thus it *cannot* be the same as discovery.site.url since that value will be /stable/updates in this case.

so *please* do not mix these things up! discovery.site.url is *not* in all cases the right site.


> Improve the way we switch between development and GA
> ----------------------------------------------------
>
>                 Key: JBDS-3191
>                 URL: https://issues.jboss.org/browse/JBDS-3191
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Enhancement
>          Components: build
>            Reporter: Mickael Istria
>            Assignee: Fred Bricon
>             Fix For: 9.0.0.Beta1
>
>
> JBDS-3190 has shown that there are too many changes to perform when willing to create a GA candidate, and it's almost certain that we'll forever forget to change one or some of them when switching between GA and development stream.
> We need to improve that.
> Changes are necessary in:
> * features/com.jboss.devstudio.core/feature/p2.inf
> * site/associate.properties
> * results/pom.xml
> As an alternative, I suggest that the final site be ALWAYS added to the referenced site, even if it's empty. This has no cost for build nor user, and this would simplify a few things here and there.
> Also, instead of a p2.inf, we could think a a "startup" extension that would add reference to development site in case qualifier for the feature doesn't contain GA.
> The property to the "current site" (GA or development) could be factorized in JBDS parent pom. so that both results/pom.xml and site/pom.xml could use it (instead of associateSites.properties).
> CC [~nickboldt] [~maxandersen]



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)