[jbosstools-issues] [JBoss JIRA] (JBIDE-17686) get TCF and RSE terminals to coexist without bad UX of multiple terminals

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-17686?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062608#comment-13062608 ] 

Rob Stryker commented on JBIDE-17686:
-------------------------------------

In a fresh m6 install, there's only one view there matching the string 'terminal' and it is in   org.eclipse.tcf.te.ui.terminals (1.3.0.201503040858)

The RSE "Remote Shell" view is still technically present, and is the default shell to open when browsing from the Remote System Explorer view. This is contributed by  org.eclipse.rse.shells.ui (3.0.500.201403271554)


> Optimally we could remove the RSE terminal and just use the new one

Removing  org.eclipse.rse.shells.ui (3.0.500.201403271554) probably won't fix anything. *WE* can just use the new one wherever we're using it, but by removing the RSE one, all we'd be doing is removing the ability to right-click on a connection in the Remote System Explorer and selecting "Launch Shell". It'd also probably break the following plugins, which seem to depend on it:

696	ACTIVE      org.eclipse.rse.subsystems.shells.core_3.1.300.201403271554
697	ACTIVE      org.eclipse.rse.subsystems.shells.dstore_2.1.400.201403100950
698	ACTIVE      org.eclipse.rse.subsystems.shells.local_2.1.400.201403100950
699	ACTIVE      org.eclipse.rse.subsystems.shells.ssh_2.1.400.201403100950
700	ACTIVE      org.eclipse.rse.subsystems.shells.telnet_1.2.300.201403100950

In order to get "Launch Shell" to open one of the new terminals, instead, we'd probably need to remove all of the above plugins *and* provide replacements for them, that implement the same extension points and fill the same niche. Otherwise we'll be losing that action from the Remote System Explorer view to open a shell. 

Lars and the Fuse tools seem to be using a deprecated and disappeared terminal view:  org.eclipse.tm.terminal.view.  Either that or I'm pretty blind. But an 'ss' command in m6 does not show this view present at all. This view (org.eclipse.tm.terminal.view) is definitely present when using a fuseide dev-env and tp, so it seems to have been recently removed.  Lars will 100% need to rewrite his terminal integration for any Mars release. It would be very very important for him to review the current proposed terminal to see it meets his API needs. 

So anyway, can TCF and RSE terminals co-exist without bad UI? Probably not.  The RSE terminal is tied to the RSE views, and simply removing them removes functionality. We could rewrite the entire terminal portion of RSE, but since RSE is being deprecated / killed softly, that seems like a big waste of time (unless we planned to continue going with RSE even when it was no longer maintained, or take it over). 

It seems to me that just leaving them in is hte better short-term fix, but if we had ideas to take over RSE entirely, then it might make sense to get rid of their old crappy terminal and migrate them to the new one. Of course whether this is even technically possible hasn't been investigated by me yet. 

> get TCF and RSE terminals to coexist without bad UX of multiple terminals
> -------------------------------------------------------------------------
>
>                 Key: JBIDE-17686
>                 URL: https://issues.jboss.org/browse/JBIDE-17686
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: upstream
>    Affects Versions: 4.2.0.Beta2
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Minor
>             Fix For: 4.3.0.Beta1
>
>         Attachments: eclipse-can-has-many-consoles.png
>
>
> luna has new Eclipse TCF terminal that brings better Terminal support.
> I would assume it is in there but I couldn't find a way to actually open it. Maybe we havent included the full set of plugins.
> http://marketplace.eclipse.org/content/tcf-terminals#.U6sJ92Vp7wV
> http://eclipsesource.com/blogs/2014/06/17/tcf-terminal-top-eclipse-luna-feature-7/



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)