[jbosstools-issues] [JBoss JIRA] (JBDS-3411) have installer build actually use M6 p2 product build

[Denis Golovin (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-3411?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13062623#comment-13062623 ] 

Denis Golovin edited comment on JBDS-3411 at 4/24/15 8:36 PM:
--------------------------------------------------------------

I found better and simpler solution. Instead of renaming $\{target-dir\}/studio and have a bunch of changes in installer, I just changed where product is materialized under Mac OS X. In attached PR p2.director target dir is changed from $\{target-dir\}/studio  to $\{target-dir\}/studio/jbdevstudio.app. That solution has all the benefits: 
1. jbdevstudio.app location doesn't change;
2. jbdevstudio.app has the same structure as Eclipse.app and it is normal Mac OS X application package that contains all Eclipse artifacts (plug-ins, features and  etc) inside;
3. jbdevstudio.ini is in right location and is not ignored anymore (BDS-3410 is fixed).

The only drawback(?) tycho 0.23.0-SNAPSHOT should be used in jbdevstudio-product build.

There are several unnecessary .png and .ico files but that is a different issue. 


was (Author: dgolovin):
I found better and simpler solution. Instead of renaming ${target-dir}/studio and have a bunch of changes in installer, I just changed where product is materialized under Mac OS X. In attached PR p2.director target dir is changed from ${target-dir}/studio  to ${target-dir}/studio/jbdevstudio.app. That solution has all the benefits: 
1. jbdevstudio.app location doesn't change;
2. jbdevstudio.app has the same structure as Eclipse.app and it is normal Mac OS X application package that contains all Eclipse artifacts (plug-ins, features and  etc) inside;
3. jbdevstudio.ini is in right location and is not ignored anymore (BDS-3410 is fixed).

The only drawback(?) tycho 0.23.0-SNAPSHOT should be used in jbdevstudio-product build.

There are several unnecessary .png and .ico files but that is a different issue. 

> have installer build actually use M6 p2 product build
> -----------------------------------------------------
>
>                 Key: JBDS-3411
>                 URL: https://issues.jboss.org/browse/JBDS-3411
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>          Components: build, installer, updatesite
>            Reporter: Max Rydahl Andersen
>            Assignee: Denis Golovin
>            Priority: Critical
>             Fix For: 9.0.0.Beta1
>
>
> talking with [~prapicault] I learned that since M6 the following changes are required for proper working p2 product/osx build:
> {code}
> <products>
>          <product>
>            ...
>            <rootFolders>
>              <macosx>MyProduct.app</macosx>
>            </rootFolders>
>          </product>
> {code}
> And to use tycho 0.23-snapshot



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)