[jbosstools-issues] [JBoss JIRA] (JBDS-2044) .eclipseproduct file no longer refers to JBDS

[Denis Golovin (JIRA)]

    [ https://issues.jboss.org/browse/JBDS-2044?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13063977#comment-13063977 ] 

Denis Golovin commented on JBDS-2044:
-------------------------------------

I've tested devstudio build without references to org.eclipse.platform feature to check if it still has all product related feature. I removed everything related to platform feature and feature itself and ran the product build. Build and installation were fine no errors no .eclipseproduct file,  but devstudio failed to start with error

{code}!ENTRY org.eclipse.e4.ui.workbench 4 0 2015-04-28 11:25:37.892
!MESSAGE Unable to load resource platform:/plugin/org.eclipse.platform/LegacyIDE.e4xmi
!STACK 0
org.eclipse.emf.ecore.resource.impl.ResourceSetImpl$1DiagnosticWrappedException: java.io.IOException: Unable to resolve plug-in "platform:/plugin/org.eclipse.platform/LegacyIDE.e4xmi".
        at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.handleDemandLoadException(ResourceSetImpl.java:319)
        at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoadHelper(ResourceSetImpl.java:278)
        at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.getResource(ResourceSetImpl.java:406)
        at org.eclipse.e4.ui.internal.workbench.ResourceHandler.getResource(ResourceHandler.java:350)
        at org.eclipse.e4.ui.internal.workbench.ResourceHandler.loadResource(ResourceHandler.java:326)
        at org.eclipse.e4.ui.internal.workbench.ResourceHandler.loadMostRecentModel(ResourceHandler.java:243)
        at org.eclipse.e4.ui.internal.workbench.swt.E4Application.loadApplicationModel(E4Application.java:398)
        at org.eclipse.e4.ui.internal.workbench.swt.E4Application.createE4Workbench(E4Application.java:255)
        at org.eclipse.ui.internal.Workbench$5.run(Workbench.java:620)
        at org.eclipse.core.databinding.observable.Realm.runWithDefault(Realm.java:337)
        at org.eclipse.ui.internal.Workbench.createAndRunWorkbench(Workbench.java:598)
        at org.eclipse.ui.PlatformUI.createAndRunWorkbench(PlatformUI.java:150)
        at org.eclipse.ui.internal.ide.application.IDEApplication.start(IDEApplication.java:138)
        at org.eclipse.equinox.internal.app.EclipseAppHandle.run(EclipseAppHandle.java:196)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.runApplication(EclipseAppLauncher.java:134)
        at org.eclipse.core.runtime.internal.adaptor.EclipseAppLauncher.start(EclipseAppLauncher.java:104)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:380)
        at org.eclipse.core.runtime.adaptor.EclipseStarter.run(EclipseStarter.java:235)
        at sun.reflect.NativeMethodAccessorImpl.invoke0(Native Method)
        at sun.reflect.NativeMethodAccessorImpl.invoke(NativeMethodAccessorImpl.java:57)
        at sun.reflect.DelegatingMethodAccessorImpl.invoke(DelegatingMethodAccessorImpl.java:43)
        at java.lang.reflect.Method.invoke(Method.java:606)
        at org.eclipse.equinox.launcher.Main.invokeFramework(Main.java:648)
        at org.eclipse.equinox.launcher.Main.basicRun(Main.java:603)
        at org.eclipse.equinox.launcher.Main.run(Main.java:1465)
        at org.eclipse.equinox.launcher.Main.main(Main.java:1438)
Caused by: java.io.IOException: Unable to resolve plug-in "platform:/plugin/org.eclipse.platform/LegacyIDE.e4xmi".
        at org.eclipse.core.internal.runtime.PlatformURLPluginConnection.parse(PlatformURLPluginConnection.java:65)
        at org.eclipse.core.internal.runtime.PlatformURLPluginConnection.resolve(PlatformURLPluginConnection.java:77)
        at org.eclipse.core.internal.boot.PlatformURLHandler.openConnection(PlatformURLHandler.java:69)
        at org.eclipse.osgi.internal.url.URLStreamHandlerProxy.openConnection(URLStreamHandlerProxy.java:114)
        at java.net.URL.openConnection(URL.java:971)
        at org.eclipse.emf.ecore.resource.impl.URIHandlerImpl.createInputStream(URIHandlerImpl.java:200)
        at org.eclipse.emf.ecore.resource.impl.ExtensibleURIConverterImpl.createInputStream(ExtensibleURIConverterImpl.java:360)
        at org.eclipse.emf.ecore.resource.impl.ResourceImpl.load(ResourceImpl.java:1269)
        at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoad(ResourceSetImpl.java:259)
        at org.eclipse.emf.ecore.resource.impl.ResourceSetImpl.demandLoadHelper(ResourceSetImpl.java:274)
        ... 24 more
{code}

After I added reference to org.eclipse.platform bundle everything went back to normal and no .eclipseproduct file. 

Only m2e* features has references to org.eclipse.platform feature and that is the reason we cannot include our own marker file with right product id in it. But as I said before that really doesn't harm anyone, because equinox will generate unique location to store its state info based on installation folder hash. 

So it is really optional issue to fix.

> .eclipseproduct file no longer refers to JBDS
> ---------------------------------------------
>
>                 Key: JBDS-2044
>                 URL: https://issues.jboss.org/browse/JBDS-2044
>             Project: Developer Studio (JBoss Developer Studio)
>          Issue Type: Bug
>          Components: installer
>    Affects Versions: 5.0.0.Beta1
>            Reporter: Nick Boldt
>            Assignee: Denis Golovin
>              Labels: discuss
>             Fix For: 8.x
>
>
> Before, with the linux x64 installer (jbdevstudio-product-linux-gtk-x86_64-5.0.0.v201202271832M-H79-Beta1.jar) the .eclipseproduct file read:
> {code}
> name=JBoss Developer Studio
> id=com.jboss.jbds.all
> version=5.0.0.v201202271832M-H79-Beta1
> {code}
> Now, with the universal installer (jbdevstudio-product-universal-5.0.0.v201202271832M-H79-Beta1.jar), it reads:
> {code}
> name=Eclipse Platform
> id=org.eclipse.platform
> version=3.7.0
> {code}
> Latest code in equinox.runtime master branch is located http://git.eclipse.org/c/equinox/rt.equinox.framework.git/tree/bundles/org.eclipse.osgi/container/src/org/eclipse/osgi/internal/location/EquinoxLocations.java#n270



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)