[jbosstools-issues] [JBoss JIRA] (JBIDE-19335) org.jboss.tools.runtime.ui.internal.wizard.DownloadRuntimeLicenseFragment fails with SWTError without browser available

[Vlado Pakan (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-19335?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13103453#comment-13103453 ] 

Vlado Pakan commented on JBIDE-19335:
-------------------------------------

To me code looks correct. SWTError is catched -> logBrowserLoadingProblem is called -> FoundationUIPlugin.pluginLog().logError(message, e) is called -> error message is displayed

{code:title=BrowserUtility.java.java|borderStyle=solid}
			try {
				return new Browser(parent, style | preferredBrowser);
			} catch (SWTError e) {
				if(!(e instanceof SWTError) && !browserLoadingErrorLoged) {
					logBrowserLoadingProblem(e, browserNames.get(preferredBrowser), true);
				}
				Control[] children = parent.getChildren();
				for (Control child : children) {
					child.dispose();
				}
{code}

> org.jboss.tools.runtime.ui.internal.wizard.DownloadRuntimeLicenseFragment fails with SWTError without browser available
> -----------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-19335
>                 URL: https://issues.jboss.org/browse/JBIDE-19335
>             Project: Tools (JBoss Tools)
>          Issue Type: Feature Request
>          Components: common/jst/core, runtime-detection
>    Affects Versions: 4.2.3.Beta1, 4.3.0.Alpha1
>         Environment: Linux
>            Reporter: Denis Golovin
>            Assignee: Denis Golovin
>             Fix For: 4.3.0.CR1
>
>
> DownloadRuntimeLicenseFragment  should work even without browser widget available and show html or text without html tags with <p> and <br> elements replaced with '\n'.
> Steps to tests the issue:
> 1. Linux disto without webkit or xulrunner (I was using xubuntu to verify)
> 2. Run JBT and try to download WildFly using Runtime Download dialog;
> 3. It should show not fail with SWTError when presenting license step, but show the link to the license, so you can click on it to open system browser or copy/past it into your favorite one
> 4. Close eclipse
> 5. Install libwebkit
> 6. Start eclipse, do WildFly downloading steps again and you should see license text inside dialog.



--
This message was sent by Atlassian JIRA
(v6.3.15#6346)