[jbosstools-issues] [JBoss JIRA] (JBIDE-21165) Need to improve js tools (npm / bower) launch

[Ilya Buziuk (JIRA)]

Ilya Buziuk created JBIDE-21165:
-----------------------------------

             Summary: Need to improve js tools (npm / bower) launch 
                 Key: JBIDE-21165
                 URL: https://issues.jboss.org/browse/JBIDE-21165
             Project: Tools (JBoss Tools)
          Issue Type: Enhancement
          Components: nodejs
            Reporter: Ilya Buziuk
            Assignee: Ilya Buziuk
             Fix For: 4.4.0.Alpha1


For now npm / bower is launched via node. Basically, this was done due to the fact that on Mac Os launched from desktop node PATH var not available:
 {quote}
env: node: No such file or directory
 {quote}
In order to handle it, it was suggested to launch npm / bower tools via node and have a preference for each tool. However, on thym project more elegant solution was found - execute the given command and returns a handle to the process. 
More details can be found here:
- https://github.com/gorkem/thym/blob/use_cli/plugins/org.eclipse.thym.core/src/org/eclipse/thym/core/internal/cordova/CordovaCLI.java#
- https://github.com/gorkem/thym/blob/use_cli/plugins/org.eclipse.thym.core/src/org/eclipse/thym/core/internal/util/ExternalProcessUtility.java

Basically, this approach kills two birds with one stone:
1. No mac os Path issue
2. No need to have preferences for node / npm / bower

Also, it will be quite easy to provide cheatsheets for this tools which will include sets of commands

The plan is:
- reimplement the launch process that will be generic for both jsdt and thym (maybe some other tools in future)
- remove irrelevant code with preferences, detectors etc




--
This message was sent by Atlassian JIRA
(v6.4.11#64026)