[jbosstools-issues] [JBoss JIRA] (JBIDE-21158) Improve BaseExplorerContentProvider.loadChildren()

[Fred Bricon (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21158?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135865#comment-13135865 ] 

Fred Bricon edited comment on JBIDE-21158 at 12/1/15 2:35 PM:
--------------------------------------------------------------

Thanks for the patch Slava. Worked fine for me, although I couldn't spot any difference, as a user.

Applied in master and 4.3.x


was (Author: fbricon):
Thanks for the path Slava. Worked fine for me, although I couldn't spot any difference, as a user.

Applied in master and 4.3.x

> Improve BaseExplorerContentProvider.loadChildren()
> --------------------------------------------------
>
>                 Key: JBIDE-21158
>                 URL: https://issues.jboss.org/browse/JBIDE-21158
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: openshift
>    Affects Versions: 4.4.0.Alpha1
>            Reporter: Viacheslav Kabanovich
>            Assignee: Viacheslav Kabanovich
>              Labels: performance
>             Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> This method may be called concurrently while children for current parentElement are being loaded. Now for this case implementation calls directly getChildrenFor(parentElement) which loads children in ui thread. So, if by some reason loading children in a separate job took a lot of time, by the same reason this second call in ui thread may hang Eclipse for some time.
> Instead, it seams reasonable just to return the available loading stub as a child, when loading job is completed it will call refresh.
> [~adietish] please take a look at the pull request.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)