[jbosstools-issues] [JBoss JIRA] (JBIDE-21176) [CDK] installing cdk feature should install docker feature

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21176?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136437#comment-13136437 ] 

Nick Boldt commented on JBIDE-21176:
------------------------------------

Yes, a feature REQUIREMENT is better than a feature INCLUDE because an include will attempt to create a source feature for all the things in the inclusion path, and since there's no docker sources in the TP, you'd need to source them from somewhere else.

Or, as you discovered, REQUIRING upstream features is better. But I still think you would be best served by REQUIRING plugins via your MANIFEST.MF since you can then lock down specific version ranges and avoid unexpected nastiness should the o.e.lt.docker.feature change API unexpectedly or start including things that conflict w/ the rest of JBT.



> [CDK] installing cdk feature should install docker feature
> ----------------------------------------------------------
>
>                 Key: JBIDE-21176
>                 URL: https://issues.jboss.org/browse/JBIDE-21176
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift, server, target-platform
>    Affects Versions: 4.3.1.Beta1
>            Reporter: Rob Stryker
>            Assignee: Rob Stryker
>             Fix For: 4.3.1.Beta1
>
>
> CDK Feature should also install docker feature. 



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)