[jbosstools-issues] [JBoss JIRA] (JBIDE-21161) various UI issues on new cdk server adapter

[Viacheslav Kabanovich (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21161?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136442#comment-13136442 ] 

Viacheslav Kabanovich edited comment on JBIDE-21161 at 12/3/15 12:18 AM:
-------------------------------------------------------------------------

GridLayout might do better than FormLayout, 'Browse' button makes 'Folder' controls to look somewhat lopsided. 

I wonder, why 'Add credentials...' is a link under 'Username:', I would suggest button 'Add...' or 'New...' to the right of its combo.

Putting credentials in a group may work, but the component may also be made more flexible to be fit into any grid. Functionality may be moved from ChooseCredentialComposite to a new class ChooseCredentialComponent which will not inherit from Composite but implement method create(Composite) that will layout its controls into parent's grid. Then ChooseCredentialComposite may aggregate ChooseCredentialComponent and call create with itself as the parent. Other clients may either reuse ChooseCredentialComposite or instantiate ChooseCredentialComponent to call create with any composite.

As a good example, take New Java Class wizard. It contains a lot of inputs, grouped into many reusable components that are fitted into provided grid layout.


was (Author: scabanovich):
GridLayout might do better than FormLayout, 'Browse' button makes 'Folder' controls to look somewhat lopsided. 

I wonder, why 'Add credentials...' is a link under 'Username:', I would suggest button 'Add...' or 'New...' to the right of its combo.

Putting credentials in a group may work, but the component may also be made more flexible to be fit into any grid. Functionality may be moved from ChooseCredentialComposite to a new class ChooseCredentialComponent which will not inherit from Composite but implement method create(Composite) that will layout its controls into parent's grid. Then ChooseCredentialComposite may aggregate ChooseCredentialComponent and call create with itself as the parent. Other clients may either reuse ChooseCredentialComposite or instantiate ChooseCredentialComponent to call create with any composite.

> various UI issues on new cdk server adapter
> -------------------------------------------
>
>                 Key: JBIDE-21161
>                 URL: https://issues.jboss.org/browse/JBIDE-21161
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: openshift
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>         Attachments: New_Server_and_Java_EE_-_Eclipse.png
>
>
> the cDK server adapter page has some "weird" UI layout.
> see attached.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)