[jbosstools-issues] [JBoss JIRA] (JBIDE-18743) write tests for download.jboss.org & devstudio.redhat.com xmlunit test cases; validate composite*.xml; *.properties validation -- check if all properties are defined (avoid boss.* vs. jboss.*)

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-18743?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136842#comment-13136842 ] 

Nick Boldt commented on JBIDE-18743:
------------------------------------

Seems Max wants more than just that... an example is that there's a couple of old orphan composite sites:

* http://download.jboss.org/jbosstools/builds/staging/_composite_/core/4.3.mars/
* http://download.jboss.org/jbosstools/builds/staging/_composite_/core/master/

which are no longer valid because we moved things around a year ago in support of JBDS-3208 (moving to the new /mars/snapshots/ structure instead of /builds/staging/).

If you point p2browser at the first site, you get:

{code}
Problems loading repository
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-aerogear_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-arquillian_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-birt_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-browsersim_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-central_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-forge_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-hibernate_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-javaee_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-jst_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-livereload_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-openshift_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-server_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-vpe_4.3.mars/all/repo/.
No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-webservices_4.3.mars/all/repo/.
{code}

Or, if you run it with the -consolelog flag, you get console log details like:

{code}
!ENTRY org.eclipse.equinox.p2.core 4 0 2015-12-03 13:05:19.958
!MESSAGE Provisioning exception
!STACK 1
org.eclipse.equinox.p2.core.ProvisionException: No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-aerogear_4.3.mars/all/repo/.
	at org.eclipse.equinox.internal.p2.repository.helpers.AbstractRepositoryManager.fail(AbstractRepositoryManager.java:393)
	at org.eclipse.equinox.internal.p2.repository.helpers.AbstractRepositoryManager.loadRepository(AbstractRepositoryManager.java:675)
	at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.loadRepository(MetadataRepositoryManager.java:96)
	at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.loadRepository(MetadataRepositoryManager.java:92)
	at org.eclipse.equinox.internal.p2.metadata.repository.CompositeMetadataRepository.addChild(CompositeMetadataRepository.java:165)
	at org.eclipse.equinox.internal.p2.metadata.repository.CompositeMetadataRepository.<init>(CompositeMetadataRepository.java:105)
	at org.eclipse.equinox.internal.p2.metadata.repository.CompositeMetadataRepositoryFactory.load(CompositeMetadataRepositoryFactory.java:122)
	at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.factoryLoad(MetadataRepositoryManager.java:57)
	at org.eclipse.equinox.internal.p2.repository.helpers.AbstractRepositoryManager.loadRepository(AbstractRepositoryManager.java:758)
	at org.eclipse.equinox.internal.p2.repository.helpers.AbstractRepositoryManager.loadRepository(AbstractRepositoryManager.java:651)
	at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.loadRepository(MetadataRepositoryManager.java:96)
	at org.eclipse.equinox.internal.p2.metadata.repository.MetadataRepositoryManager.loadRepository(MetadataRepositoryManager.java:92)
	at com.ifedorenko.p2browser.views.MetadataRepositoryView.loadRepository(MetadataRepositoryView.java:614)
	at com.ifedorenko.p2browser.views.MetadataRepositoryView.access$13(MetadataRepositoryView.java:599)
	at com.ifedorenko.p2browser.views.MetadataRepositoryView$12.run(MetadataRepositoryView.java:524)
	at org.eclipse.core.internal.jobs.Worker.run(Worker.java:54)
!SUBENTRY 1 org.eclipse.equinox.p2.metadata.repository 4 1000 2015-12-03 13:05:19.960
!MESSAGE No repository found at http://download.jboss.org/jbosstools/builds/staging/jbosstools-aerogear_4.3.mars/all/repo/.
{code}

So we could potentially run this in Jenkins to read sites and check their contents, then parse the console log for "No repository found at ..." messages.

> write tests for download.jboss.org & devstudio.redhat.com xmlunit test cases; validate composite*.xml; *.properties validation -- check if all properties are defined (avoid boss.* vs. jboss.*)
> ------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-18743
>                 URL: https://issues.jboss.org/browse/JBIDE-18743
>             Project: Tools (JBoss Tools)
>          Issue Type: Enhancement
>          Components: build
>    Affects Versions: 4.2.0.Final
>            Reporter: Nick Boldt
>             Fix For: 4.3.x
>
>
> We need to write tests for download.jboss.org & devstudio.redhat.com:
> * xmlunit test cases
> ** validate composite*.xml
> ** unit testing for discovery plugin.xml, update site category.xml (avoid bad URLs like 8.0-staging in a milestone release)
> * other test cases
> ** \*.properties validation -- check if all properties are defined (avoid boss.* vs. jboss.*)



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)