[jbosstools-issues] [JBoss JIRA] (JBIDE-21145) Component-install job does not reliably install all JBT IUs and so does not see changes between CI builds

[Nick Boldt (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21145?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13137383#comment-13137383 ] 

Nick Boldt edited comment on JBIDE-21145 at 12/4/15 4:22 PM:
-------------------------------------------------------------

As to the notion that it's as fast or faster to do:

* p2 diff check comparing composite with [some other composite which doesn't exist, or some aggregate which is by definition different*]
* JBT aggregate build
* JBT aggregate p2 director install test

than to do:

* JBT composite p2 director install test
* JBT aggregate build
* p2 diff check comparing local JBT aggregate with last published JBT aggregate

Yes, you're right... it would be about as much time either way. But since we don't have a composite site snapshot against which to compare (the composite site is only ever a single "latest snapshot"), I can't see how you'd perform a p2diff check BEFORE doing a build of the JBT aggregate, then comparing that against the previous aggregate. 

So, *TL;DR*... I can set up a p2diff check of the aggregate repo after it's built and before it's published, even though you more or less said that the SHA check was good enough. See JBIDE-16970 for future discussion on that topic.

\* - it's always different because the composite includes test plugins and the aggregate does not. So we're always testing a DIFFERENT install than the p2director (everything in JBT+Central+EA / JBDS+Central+EA, via headless install) and install-grinder (everything in JBT+Central+EA / JBDS+Central+EA, via UI install). 



was (Author: nickboldt):
As to the notion that it's as fast or faster to do:

* p2 diff check comparing composite with [some other composite which doesn't exist, or some aggregate which is by definition different*]
* JBT aggregate build
* JBT aggregate p2 director install test

than to do:

* JBT composite p2 director install test
* JBT aggregate build
* p2 diff check comparing local JBT aggregate with last published JBT aggregate

Yes, you're right... it would be about as much time either way. But since we don't have a composite site snapshot against which to compare (the composite site is only ever a single "latest snapshot"), I can't see how you'd perform a p2diff check BEFORE doing a build of the JBT aggregate, then comparing that against the previous aggregate. 

So, *TL;DR*... I can set up a p2diff check of the aggregate repo after it's built and before it's published, even though you more or less said that the SHA check was good enough. See JBIDE-16970 for future discussion on that topic.

* - it's always different because the composite includes test plugins and the aggregate does not. So we're always testing a DIFFERENT install than the p2director (everything in JBT+Central+EA / JBDS+Central+EA, via headless install) and install-grinder (everything in JBT+Central+EA / JBDS+Central+EA, via UI install). 


> Component-install job does not reliably install all JBT IUs and so does not see changes between CI builds
> ---------------------------------------------------------------------------------------------------------
>
>                 Key: JBIDE-21145
>                 URL: https://issues.jboss.org/browse/JBIDE-21145
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: build
>    Affects Versions: 4.3.1.Beta1, 4.4.0.Alpha1
>            Reporter: Pavol Srna
>            Assignee: Nick Boldt
>            Priority: Blocker
>             Fix For: 4.3.1.Beta1, 4.4.0.Alpha1
>
>
> We have often seen old artifacts on nightly sites (mars and neon too). 
> It seems that the composite-install job [0], [1] is not reliable. So, the downstream JBT aggregate builds [2], [3] are not triggered automatically to pick up all new changes in the upstream JBT component site builds.
> [0] http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-composite-install_master/lastBuild/console
> [1] http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-composite-install_4.3.mars/lastBuild/console
> [2] http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.site_master/ (latest build shows: "Nov 27, 2015 6:15 AM NOT ​PUBLISHED: ​​UNCHANGED")
> [3] http://jenkins.mw.lab.eng.bos.redhat.com/hudson/job/jbosstools-build-sites.aggregate.site_4.3.mars/ (latest build shows: "Nov 27, 2015 3:43 AM NOT ​PUBLISHED: ​​UNCHANGED")
> Please investigate.
> Thanks!



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)