[jbosstools-issues] [JBoss JIRA] (JBIDE-21192) jboss-runtimes are still not scanned

[Rob Stryker (JIRA)]

     [ https://issues.jboss.org/browse/JBIDE-21192?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Rob Stryker resolved JBIDE-21192.
---------------------------------
    Resolution: Done


https://github.com/jbosstools/jbosstools-base/commit/b495a62ef0414738f735a14a81c5cdf36689978a

It currently does add jboss-runtimes as a path to scan on every startup.  However, you are correct, it does NOT do this if the folder doesn't exist on first startup. 

The fix is to ensure it adds the RuntimePath to be scanned regardless of whether the jboss-runtimes folder actually exists at the first startup or not.  The path will be invalid if the folder doesn't exist, but there's no other harm or damage, as it's already defensively coded to ignore paths that don't exist. 

It does seem a bit weird to add a path to be scanned when the path doesn't exist, but the alternatives (re-adding the path even if a user intentionally removed it? trying to figure out if it was added in the past and removed and customize logic to POSSIBLY add it?)  all seem more complicated, and possibly confusing to the user;  very voodoo magical.   Adding the invalid path is the most logical. 

> jboss-runtimes are still not scanned 
> -------------------------------------
>
>                 Key: JBIDE-21192
>                 URL: https://issues.jboss.org/browse/JBIDE-21192
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: runtime-detection
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>             Fix For: 4.3.1.Beta1
>
>
> JBDS-2515 requested that ~/jboss-runtimes would be scanned but seem to have ended up being to only add this on new workspaces and *only* if the location exist when creating the new workspace.
> I found no way to have restore defaults or any way to actually have the scan happen.
> Why are we not always adding ~/jboss-runtimes to the list of locations to scan no matter if the location exists or not ?



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)