[jbosstools-issues] [JBoss JIRA] (JBIDE-21193) runtime detection detects *any* folder as a CDK and jboss multiple times

[Rob Stryker (JIRA)]

    [ https://issues.jboss.org/browse/JBIDE-21193?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13138601#comment-13138601 ] 

Rob Stryker commented on JBIDE-21193:
-------------------------------------

I have no idea, Max ;)    The API asks a given runtime detector for a "RuntimeDefinition" given some file / folder.   The RuntimeDefinition that's returned has a name, version, type, etc.  But there's no clear mechanism that links it to a specific runtime detector. 

So,   if there's a given workspace with two runtime detectors,  WonkaDetector and JBossDetector,  and it's provided two paths  (~/wonka,  ~/jboss),  both will be asked to create a RuntimeDefinition for each path. The wonka detector will return one for wonka, the jboss detector one for jboss. But, it should be noted, there's no 1:1 mapping between the runtime definition type and a given detector. So the jboss detector can return a RuntimeDefinition of type EAP, or type JPP, or type EWP, etc etc.   The type is just an identifying string. There's no reference to the detector that instantiated it. 

Anyway, it's expected that a given detector knows what "types" it made, and handles them. So a wonka detector knows it only creates wonka type runtime definitions, and if its given anything else, it should ignore it. 

I'm sure changes could be made to AbstractRuntimeDetectorDelegate to add some protected methods and add a constructor to RuntimeDefinition to include the given detector and optimize the behavior... but it's not really a huge priority since every detector knows what types htey create.  But it'd definitely make the api nicer. 

> runtime detection detects *any* folder as a CDK and jboss multiple times
> ------------------------------------------------------------------------
>
>                 Key: JBIDE-21193
>                 URL: https://issues.jboss.org/browse/JBIDE-21193
>             Project: Tools (JBoss Tools)
>          Issue Type: Bug
>          Components: runtime-detection
>            Reporter: Max Rydahl Andersen
>            Assignee: Rob Stryker
>            Priority: Blocker
>             Fix For: 4.3.1.Beta1
>
>         Attachments: Java_EE_-_jboss-eap-6_1_CDK_Server_-_Eclipse.png
>
>
> with build from last week I now get this list of runtime detected in my folder of servers.
> At first I thought it was the CDK being weird but something is also very weird about the basic runtime detection since I seem to have multiple WildFly 8.0's...as opposed to using the folder name.
> Here is the content of my folder
> {code}
> apache-karaf-2.3.5
> apache-tomcat-7.0.35
> app.js
> app.js.1
> fsw-6
> jboss as 7
> jboss-5.1.0.GA
> jboss-as-7.0.1.Final
> jboss-as-7.1.0.Final
> jboss-as-7.1.1.Final
> jboss-as-web-7.0.0.Final
> jboss-as-web-7.0.2.Final
> jboss-eap-6.0.1
> jboss-eap-6.1
> weld-1.1.0.Final
> weld-1.1.5.Final
> wildfly-10.0.0.CR4
> wildfly-8.0.0.Beta1
> wildfly-8.0.0.Final
> wildfly-8.1.0.Final
> wildfly-8.2.0
> wildfly-core-8.0.0.Final
> {code}
> and attached is the list I get.



--
This message was sent by Atlassian JIRA
(v6.4.11#64026)